fix(next): land the web base-red fixes together (react-apps-check)

Merged
TE
16d ago
+16-11

The web base reds on feat-cmux-next deadlock each other: next-autoland never excuses a web / react-apps-check red on a PR that touches web, so each single fix PR stays red on the others' failures and none can land. This PR merges the reviewed fix PRs into one branch so the whole set lands in one go. Each part was reviewed on its own PR by an independent subagent, and every review approved.

PartRed it fixesRoot cause
#22490markdown-table-keys Cmd-A; vp check formatting; 10 TS2345 on import.meta.hot.onjsdom navigator.platform on Linux makes ProseMirror's Mod Ctrl; 5 unformatted settings files; a stray bun-types reference
#22343composer-type-scale model-menu-starredgallery state
#22504new-tab-warm-first-frame (8)Cards template (3 cards, now the default) left the device chat no slot
#22508status-glyphs (9)Lawrence's deliberate talk-bubble removal; the test still expected the bubble
#22511markdown-selection-drag Cmd-A, markdown-table-obsidian reload widthLinux Mod key; the gallery's fake host lacked setTableWidths / tableWidths after widths moved to the xattr
#22509webviews check gate: check:text-focus (3 Swift fields), 10 lint warnings (denyWarnings), check-layers on findPill.cssnew code without the fallback or suppression the checkers ask for

When this lands, the six PRs above have nothing left to merge.

One visible change, from #22509: the Todo page's done mark uses Palette.accent, the theme's accent, instead of the system blue that check-system-blue forbids. In the neutral theme it draws gray.

Not in here: the categories.test.ts Screenshots rows (#22497, which needs a Mac regeneration) and the Swift and defaults-snapshot reds.

Verification

On Huge Blue (Linux, bun 1.4.2, Playwright chromium and webkit), each part's PR has its test runs: every named file passes at its head. CI on this PR is the combined check.

Risk

Low. Test, fake-host and lint-comment changes, plus one CSS fallback, two .focusEffectDisabled() and one theme color.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Lands the web react-apps-check base red fixes on feat-cmux-next together, since each single-fix PR stays red on the others' failures. Conflicts with #22516, which landed the same gallery-host, status-glyphs, whats-new, and starred-gallery fixes, are resolved by keeping the base versions.

Bug Fixes

  • The page reports MacIntel before ProseMirror loads, so Cmd-A and Select All work on Linux CI.
  • The gallery mock host answers cmux.markdown.setTableWidths, stores widths in sessionStorage, and the kept-width test reloads only after the host stores the width.
  • The find pill gets a prefers-reduced-transparency fallback; the Density card and seven lint warnings get line-level suppressions; five settings files are reformatted; a stray bun-types reference is dropped.
  • new-tab-warm-first-frame expects two sessions and one device chat to fill the three cards of the default Cards template.
  • status-glyphs expects the attention dot, not the talk bubble, for waiting, and tells it from done by color.
  • model-menu-starred opens a new chat because only a new chat's harness has a Starred rail.
  • The whats-new Updated card test follows the new headline layout.
  • Three Swift text fields get .focusEffectDisabled() or a text-focus-allow comment; WorkspaceTodoRow.swift is back to base.
  • The no-capsules test lists the Cards New Tab template's five pill controls as deliberate.

No visible Chrome behavior changes remain beyond the cmux-next.json defaults rebind: opt+cmd+left/right now focus left/right instead of switching sidebar tabs.