fix(next): the Starred models gallery state is a new chat (composer-type-scale base red)

Closed
TE
16d ago
+5-2

Problem

composer-type-scale.test.ts "agent-pane.composer model-menu-starred draws its text on the type scale" fails at the base (cmux-next web push run 39359066751), so every webviews PR inherits it:

"the play did not run: play: no element for option \"Starred\""

#22226 fixed a started chat's harness: its model menu has no rail, so no Starred tab (ModelPicker.tsx, {!harnessFixed && (<ScrollArea ... rail>)}). The composer gallery's model-menu-starred state still drew a finished chat (chat(finished, ...), turnCount > 0, so locked in ComposerPickers.tsx). Its play typed and starred Sonnet, then found no Starred tab.

Change

composer.gallery.ts: model-menu-starred opens a new chat (ready: { newSession: true }, noChat(...), the same shape as new-chat), where the rail and its Starred tab live. The note says why. No product code changes; the menu is right.

Testing

On Huge Blue, CMUX_BROWSER_TESTS=1 bun test test/composer-type-scale.test.ts:

  • Base ec0248b769b8, -t model-menu-starred: 1 fail, the error above.
  • Head: -t model-menu-starred 1 pass; the whole file 41 pass, 0 fail.

Observed / Not run

Observed: the runs above. Not run: the app; this is a gallery-fixture-only change. CI runs the rest of the web suite.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the composer-type-scale base red by changing the model-menu-starred gallery state to open a new chat, where the model picker's rail and Starred tab exist.

The previous state drew a finished chat; #22226 fixed a started chat's harness so its model menu has no rail, leaving no Starred option for the test to find. This updates the gallery fixture only (same shape as new-chat), with no product code changes.