webviews: status-glyphs test expects the attention dot for a wait (base red)

Closed
TE
16d ago
+19-15

webviews/test/status-glyphs.test.ts fails 9 of 12 tests on feat-cmux-next, which turns web / react-apps-check red on every PR.

Lawrence deliberately replaced the talk bubble with the attention dot for "waiting on you" on 2026-10-20. Two commits did it:

  • 3207401535b6 changed the Codex-like set, so waiting draws dot in the warning tint.
  • 301bd2794ea1 redrew the Static waiting glyph as a filled disc.

The schema, the generated TS/Swift and the gallery notes all say "no talk bubble". The test still expected the bubble:

  • Codex tests (6 failures). The drawn names were ["idle","dot","shieldLine","dot","info"] but the test expected waiting second. Its color check looked glyphs up by name, so it would also have picked the wrong dot. Its "apart by shape" loop would have failed on the two dots too, since they share a shape.
  • Sheet tests at 2x (3 failures). The waiting edge probes traced the bubble's outline: 10,2=0, 10,3=0, 10,4=229, 1,8=0, 2,8=0.

The product change was intended, so this PR changes only the test:

  • Codex tests: expect dot for waiting. Colors are now read by state position. The tests check that done is Codex blue, that waiting's dot isn't that blue, and that the error's red isn't the permission grey. The shape-difference check skips the waiting/done pair, which the colors tell apart.
  • Sheet tests at 2x: the waiting probes now sit on the new disc's top, left and bottom edges.

Verification, on Huge Blue (Linux, Chromium via Playwright): CMUX_BROWSER_TESTS=1 CI=1 bun test test/status-glyphs.test.ts went from 3 pass / 9 fail to 12 pass / 0 fail. vp fmt --check, vp lint and gen-status-glyphs.py --check are clean.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the web / react-apps-check failure by updating status-glyphs.test.ts to match the intentional glyph change that replaced the waiting talk bubble with the attention dot.

  • Expects dot for waiting in the Codex-like set, and distinguishes waiting from done by color instead of shape.
  • Updates the 2x Sheet edge probes to trace the new disc outline.