fix(desktop): move the ship controls back into the workspace tab bar

Merged
SA
1mo ago
+70-111

Reverses #7958. The Changes/PR control and the open-in button return to the pane tab bar's trailing slot, before the sidebar toggle, so they stay reachable while the right sidebar is closed. The sidebar's top strip is back to Pages and Run.

  • Closing Changes takes the sidebar down with it again when the sidebar is on the Changes tab; getWorkspaceSidebarTab and its test return.
  • The strip keeps its 48px height from #8023 and still sizes the Run hotkey hint off the strip width.

Screenshots from the dev app (sidebar open, Changes open, sidebar closed): https://app.superset.sh/page/ship-controls-back-in-the-tab-bar-379gxd

Verified over CDP: pills visible with the sidebar open and closed; one click opens the Changes pane and the sidebar on Changes, a second click closes both. Desktop typecheck, the 362 tests under the route, and Biome pass.

Co-Authored-By: Claude noreply@anthropic.com


Summary by cubic

Moves the Changes/PR control and open-in button back to the workspace tab bar's trailing slot, ahead of the sidebar toggle, so they stay reachable while the right sidebar is closed. The sidebar's top strip is back to Pages and Run, and the 48px strip height from #8023 is kept.

  • Closing Changes closes the sidebar with it again when the sidebar is on the Changes tab, via the new getWorkspaceSidebarTab read.
  • The Changes control is slightly taller to fit the tab bar.
  • Drops the host-service probe that raced two worktree adds against git itself.

Summary by CodeRabbit

  • Interface
    • The Changes control and Open In button now appear in the workspace tab bar instead of the sidebar. The Open In button remains available even when the sidebar is closed.
    • The Changes control has more vertical space, and the sidebar header layout has been adjusted.
  • Bug Fixes
    • Closing the Changes pane no longer closes the sidebar when a different sidebar tab is selected.

Also drops the host-service probe bug-hunt-3: parallel workspace.create calls for different branches can race on the same .git/config. It raced two worktree adds against git itself and failed this PR's first run with failed to read .git/worktrees/a/commondir; its own note said to retire it once it started failing.