feat(desktop): move ship controls into the workspace sidebar strip

Merged
SA
2mo ago
+47-79

Summary

  • The Changes/PR control and the open-in button move from the pane tab bar to the left of the right sidebar's top strip, next to Pages and Run. They are not in the tab bar anymore, so they are hidden while the sidebar is closed.
  • The controls sit in a one-line wrapping row with overflow hidden. Open-in drops out when it does not fit beside the Changes control, whose width follows the diff. The diff stats shrink first, so the ship chevron stays reachable at the 240px minimum.
  • The Run ⌘G hint follows the strip width (container query) instead of the viewport. The Changes control is 24px tall to match the other buttons in the strip.
  • toggleChangesPane no longer closes the sidebar together with the pane. The button now lives in the sidebar, so it vanished under the cursor. getWorkspaceSidebarTab has no other callers and is removed.

Screenshots: https://app.superset.sh/page/ship-controls-in-the-sidebar-srxir9

Known trade-off

The ⌘O open-in hotkey is registered by the button, so it does nothing while the sidebar is closed. Command palette Open-in still works.

Verification

  • Real clicks in the dev app over CDP. Toggling Changes 4× from the strip: the pane opens and closes, the sidebar stays open, and the button does not move.
  • With the sidebar closed, the tab bar has no Changes or open-in button (DOM check and screenshot).
  • Drag sweep of the sidebar at 240/280/320/340/400/540px. Open-in is hidden below the width it needs and shown at 340px and above. The chevron is always inside the row. A PR badge fits at 240px.
  • bun test in v2-workspace: 377 pass. No typecheck errors in the touched files.
  • Not checked: the "Create PR" face (clean tree, commits ahead), light theme, Windows.

Summary by cubic

Moves the Changes/PR control and the open-in button from the pane tab bar into the left of the right sidebar's top strip, next to Pages and Run, so they're hidden while the sidebar is closed.

  • The controls sit in a one-line wrapping row with overflow hidden; open-in drops out when it stops fitting beside the Changes control, whose diff stats shrink first so the ship chevron stays reachable at 240px.
  • The Run ⌘G hotkey hint now keys off the strip width via a container query instead of the viewport, and the Changes control is 24px tall to match the strip.
  • Toggling Changes no longer closes the sidebar, since the button now lives inside it; the now-unused getWorkspaceSidebarTab is removed.
  • Trade-off: the ⌘O open-in hotkey is bound by the button, so it does nothing while the sidebar is closed — command palette open-in still works.

Summary by CodeRabbit

  • UI Updates
    • Moved Changes and Open In controls from the tab bar to the workspace sidebar header.
    • Adjusted the Changes control layout to fit more compactly, and made the run-button keyboard shortcut hint adapt to the available sidebar space.
  • Behavior Changes
    • Closing the Changes pane no longer automatically closes the right sidebar.