#31476 Agent pane: the other-install approval line shows only while a request waits

Leo, on the line "This chat runs on another cmux install's agent service. Approve its requests in that app." drawn as floating text over the top of his message bubble: "yuck more garbage".

What was wrong

The line (cx-fcaq, AgentPaneView+OtherInstallNotice.swift) is a bare native label pinned over the web view below the tab row. It showed on every chat whose daemon belongs to another cmux install (NIGHTLY and Release share ~/.acpmux), even when nothing was waiting for approval. Approve-all and bypass chats never have anything to approve, so there it was only clutter on top of the transcript.

Fix

The line now shows only while that install's daemon runs the chat and the shown chat has a request waiting (decisions.questions(session:) is non-empty). It is refreshed whenever question state changes or the shown session changes, so it disappears once the request is answered. The text and the reason for it are unchanged.

AgentPaneView.showsOtherInstallNotice(otherInstall:requestWaiting:) holds the rule; AgentPaneOtherInstallNoticeTests covers all four cases. The test is committed before the fix, so on base it fails to compile.

Earlier history: the line came in with 0f7671eead5 (cx-fcaq), and #22769 moved it below the shared tab row. No single PR regressed it: it has shown this way since it was added.

Follow-up: while a request waits, the line still has no background of its own. A real slot in the web view's Notice stack would fix that. The remote-approvals notices in AgentPaneView+RemoteApprovals.swift have the same pattern.

Observed / Not run

• prepush-gate.py: no new violations.
• A fleet Swift compile and test of CmuxNextAgentPaneTests was dispatched in the background; its result will be posted as a comment.
• No capture: the visible change is that the line is gone from chats with nothing to approve.

Changelog

Fixed: the "Approve its requests in that app" line no longer floats over chats that have nothing to approve.

Agent session: agent session

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes the "Approve its requests in that app" notice so it no longer floats over chats that have nothing to approve.

• The line shows only while another cmux install's daemon runs the chat and the shown chat has a request waiting; it disappears as soon as the request is answered.
• It refreshes whenever question state or the shown session changes, so it always reflects the current chat.
• The text and the reason for the notice are unchanged.
• One gap remains: while visible, the line still has no background of its own; the remote-approvals notices in the web view share the same pattern.