Model picker: preserve menu readability and aligned shortcut columns (carries #29615)

TE
5d ago
+84-10

Leo (2026-10-31): "plus all this dummy stuff in the model picker" (right after "why didn't you guys remove the icons nor the tokens", "nor align").

Carries #29615 at c814a1d1991adb5b40b281fb3ea550e4ea380031 with all original commits and authorship intact after the coordinator handed it over and the ownership claim was refused. Spec: leo-workspace design/model-picker.md.

The compact menu and its side menus use the text-bearing glass tint and stronger menu frost so the transcript does not read through them. Every model row puts effort, star, then its shortcut or current-model check on a shared right edge. The effort target covers only its level and chevron, keeping the middle of the row clickable for model selection.

Validation at this exact head from #29615: CI passes; fleet model-pick-prompt-focus 28/28 and agent-pane-model-sticks 2/2. The original layout validation passed 21/21; glass and layer checks passed. Exact-head review: https://github.com/manaflow-ai/cmux/pull/29615#issuecomment-6550479615 . The earlier independent Codex review and visual verdict are https://github.com/manaflow-ai/cmux/pull/29615#issuecomment-6548996551 . This carry adds no code changes.

Risk: CSS grid overlay on model rows; the effort and star siblings receive pointer events in their trailing columns. The gallery press-drag-release play targets the model name. Keyboard order is unchanged.

Changelog

  • The model picker menu no longer shows the chat through it, and its shortcut keys line up on one right edge.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Makes the model picker menu opaque and aligns every row's shortcut key on a shared right edge.

  • The compact menu and its side menus no longer let the chat read through them.
  • Each model row ends in the same trailing columns: effort, star, then shortcut key (or running-model check) at the menu's edge.
  • The effort item now covers only its level and chevron, so clicking the middle of a row picks the model.
  • Carries #29615 with no code changes; updates the gallery press-drag-release play and layout tests to match.