base red: tests expect the arrow over clickable things, as 463e538e made the rule

Merged
TE
6d ago
+17-18

Base red, from web / react-apps-check (1), (3) and (4) on feat-cmux-next. 463e538e ("cmux-next: the arrow over every button, row, chip, tab and link", from the ask "change all pointers back to cursor-default") made cursor: default the rule for clickable things. Five tests still expected the pointing hand:

  • composer-chip-press.test.ts: "the pointing hand over every chip" (Chromium and WebKit, every stage)
  • inline-video.test.tsx: "every control a click lands on shows the pointing hand" (reads chips.css)
  • new-tab-omnibar-pointer.test.ts: "the pointing hand over a button"
  • running-strip.test.ts: "hover fills the whole line ... with the hand"

These tests now expect default, and the names and comments now say "the arrow". The other assertions in them (I-beam over the field, press tone, no focus ring) are unchanged. clickable-cursor.test.ts's LaneNoticeBatch offender was already fixed on base by #28856, so this PR does not touch it.

Only test changes.

Takes back #24033: 463e538e replaced #24033's pointing-hand rule with the arrow ("change all pointers back to cursor-default"); these tests follow the new rule.

Agent session: agent session

šŸ¤– Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Updates five test files that still expected the pointing-hand cursor after 463e538e made cursor: default the rule for all clickable things.

  • composer-chip-press, new-tab-omnibar-pointer, and running-strip tests now expect the arrow over chips, buttons, and agent lines.
  • inline-video now asserts cursor: default for the poster and action controls in chips.css.
  • Test names and comments now say "the arrow"; non-cursor assertions are unchanged.
  • clickable-cursor is untouched; its offender was already fixed on base.