cmux NEXT: Add Machine… in the environment picker; Add Device lists ssh config hosts and New Cloud VM…

Merged
TE
1mo ago
+435-23

Leo asked: "and why dont i see that the acpmux things are there? how is our setup flow anyways? like cmux-next remote and whatnot" and "plus the fucking qr code or whatever easy setup for my phone just like codex".

This is the UI part of "add a machine in one or two clicks". It goes with:

  • #25822: enroll's update step, so the daemon a machine gets is kept current;
  • #25939: that step's checklist row;
  • #25838: the ~/.ssh/config rows in cmux device list.

Each lands on its own: this PR reads the rows' found field when it is there.

What changes

  • Environment picker: "Add Machine…" is the last row.
    • Click it to open Add Device (device.add), now an action an agent tab may run (AgentPaneModel.connectActions, CONNECT_ACTIONS.addMachine).
    • There, Add next to a computer runs the enroll. The daemon is installed, and kept current by the update step from #25822.
    • The picker's list and grouping are untouched. That is the picker lane's area. This adds one action row to the New environment section, after SSH… and Connect Phone…. The Cloud section keeps New Cloud Machine.
  • Add Device:
    • The network way also lists ~/.ssh/config hosts, labelled "From your ssh config". They list even when Tailscale is missing or signed out, under the reason it gives.
    • Its footer gains New Cloud VM…, which runs the app's New Cloud Machine. Signed out, sign-in starts instead, the same fallback the agent pane uses.
    • The button shows on the network way, and on "Set up a new device" for a computer. The card opens on that way when the network lists nothing to add, so New Cloud VM… is never hidden there.
  • debug.add_device (DEBUG only) opens Add Device on a fixture listing, so captures never show the capture host's own tailnet. A before capture of the real card was refused by the privacy check for exactly that. way: "auto" opens the card as it opens on its own.
  • Strings: 3 new strings, 21 languages each. en and ja are translated; the rest are needs_review, as each catalog does.

Before / after

Fleet DEV builds on capture minis, fresh profiles. Before is feat-cmux-next at 5bcde1b2; the Add Device after is this branch at 8a11f3be. Later commits rebase onto base (Connect Phone…, then the picker's full machine list in #25955), fix a string-catalog entry, add New Cloud VM… to "Set up a new device" and add a debug parameter. The new-device way is captured below at the head, with its before.

Add Device, after. Captured on a fixture listing (debug.add_device), because the capture check refuses a mini's real tailnet. The card lists the network's computers and two ~/.ssh/config hosts, then the same card with no Tailscale: the ssh hosts still list under the reason. The footer has New Cloud VM….

lightdark
Add Device after, lightAdd Device after, dark

Before, there was no ssh-config row and no Cloud button. The real card's before capture was refused for showing the mini's tailnet.

Add Machine, before (unchanged by this PR; the card Add opens):

lightdark
Add Machine before, lightAdd Machine before, dark

Add Device opens on "Set up a new device" when the network lists nothing to add. Fixture listing with no computers (debug.add_device {way: "auto", computers: []}). Before: Cancel and Copy Line only, so New Cloud VM… was out of reach. After: New Cloud VM… sits between them.

lightdark
beforenew device before, lightnew device before, dark
afternew device after, lightnew device after, dark

The before is this branch's head with the footer change reverted, since base has no way parameter for the fixture.

Environment picker. Before: Local, Cloud (New Cloud Machine, Open Cloud…), New environment (SSH…, Connect Phone…). After: the same, plus Add Machine… as the last row.

The picker names the capture computer itself, and the capture check refuses a fleet mini's name in PR media, so the picker has no capture here. environment-picker.test.tsx checks the row is last and that it runs addMachine → device.add.

Risk

Low:

  • One more allowlisted action for the agent pane. It opens a card and needs the person's click; the gesture is consumed as before.
  • One more footer button.
  • One more decoded field: found, optional, defaulting to false.

No list grouping, defaults or Labs gates change.

Tests

  • AddDeviceFlowTests:
    • New Cloud VM… runs the create flow, from the network way and from "Set up a new device" when nothing is left to add;
    • ssh-config rows list with the network down and render their label;
    • the listing's found field parses.
  • environment-picker.test.tsx: the new row is last, and runs addMachine → device.add.
  • Runs: AddDeviceFlowTests 15/15 on the fleet; webviews tests, lint and typecheck on Linux.

Agent session: agent session

🤖 Generated with Claude Code