land: storage-floor

Merged
AF
16h ago
+2726-263

Accepted agent delivery; branch-keyed search descriptor included.


Summary by cubic

Keeps file tools, undo, backup capture, and multi-file operations away from AFT's own storage files and live SQLite aliases, including their hard links and WAL/shm sidecars.

  • Storage-floor decisions precede project-root and capability-grant exceptions, so grants cannot create carve-outs; snapshot, restore, and undo reject storage paths before reading any content.
  • Live SQLite aliases are detected through a shared native Windows volume/file-index and link-count query; ordinary project hard links and owned task output reads keep working.
  • Glob edits and read-only list tools report denied candidates under skipped_files with a denied_floor reason; glob edit write checks run only after content matches so unrelated outside-root symlink targets are skipped instead of aborting the edit (#804).
  • Outline validates leaves before opening them, indexed grep reads are guarded, and a single explicit zoom target returns denied_floor.
  • Read-list calls load policy, scoped grants, and pending launch-grant state once per call, keyed by context, request, scope, and approval route; nested calls discard memoized values when authority changes.
  • Glob admission stays bounded to the existing 100-file page and 256-item refill allowance; unchecked tails report null total with a verified lower bound, candidate count, and unexamined count, and omissions are reported in discovery coordinates without re-filtering matched candidates.
  • The configured storage.cache_dir root also sits on the floor, and lazy undo guards content_bytes at its on-demand disk read.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge, with a non-blocking issue in the reported glob count.

Findings

  1. P2 Glob counts unchecked files ▶

Summary

Protects AFT storage and live SQLite aliases from file tools, backup capture, and undo.

  • File tools keep AFT storage and live SQLite files off limits.
  • Backup and undo check storage paths before reading or restoring them.
  • List and edit tools skip protected paths and report what they left out.
  • Read-list calls reuse one access-policy snapshot for each request.

Reviews (8) · Last reviewed commit: "mason: restore glob's discovered-candida..." · Reviewed by Greptile