test(desktop): account for PATH augmentation on macOS
What & why
On macOS a login shell can omit /usr/local/sbin. The subprocess environment intentionally prepends missing Homebrew/common directories, but the integration test compared the result to the raw shell PATH. It failed on a working setup while validating #9625.
Compare the result with the shell path after its public platform-specific augmentation. Keep the existing checks for string variables and Windows Path. The separate fallback tests cover exactly which directories get added and how existing entries are handled.
How I tested it
- macOS, Bun 1.4.3: the original assertion failed with an extra
/usr/local/sbin. Including that directory in the shell environment also reproduced why this passes on some machines. - After the change, the complete git utility and PATH fallback test files passed: 46 tests, 83 assertions.
- Full lint and typecheck passed (42 typecheck tasks). The default full run stopped at the separate recurrence display-format failure tracked in #9658.
Summary by cubic
Fixes the shell environment integration test on macOS so it no longer fails on valid setups.
The test compared the process PATH to the raw shell PATH, but the subprocess intentionally prepends missing Homebrew directories on macOS. The test now applies the same platform-specific augmentation before comparing, while keeping existing checks for string variables and Windows Path.
Summary by CodeRabbit
- Tests
- Updated the shell environment test to account for macOS-specific
PATHadjustments.
- Updated the shell environment test to account for macOS-specific