test(shared): compare overnight recurrence slots by timestamp

PR
6h ago
+13-17

What & why

The overnight BYHOUR regression test fails on macOS when the English date formatter puts “at” between the date and the time. The returned run times are correct. Compare all 12 UTC instants in order, including the next evening's slot and the ten-second offset inherited from DTSTART. This keeps the New York time zone and midnight boundary in the test fixture.

The failure showed up while validating #9625. This patch changes only the recurrence test.

How I tested it

  • Reproduced the date-format mismatch on macOS with Bun 1.4.3. With this change, all 53 tests in packages/shared/src/rrule.test.ts pass (108 assertions).
  • Repository lint and typecheck passed (42 typecheck tasks).
  • The default full macOS suite stopped at the unrelated five-second translation display-only source-scan timeout. The full suite is not reported as passing.

Summary by cubic

Fixes the overnight recurrence test so it passes on macOS, where the English date formatter inserts “at” between the date and time.

Compares the 12 UTC instants directly by timestamp instead of formatting them into locale-dependent strings. The New York time zone and midnight boundary stay in the fixture, and the assertions now include the next evening's slot plus the ten-second offset inherited from DTSTART.

Summary by CodeRabbit

  • Tests
    • Updated automated coverage for overnight recurring schedules to verify returned occurrences in UTC. The expected results now explicitly cover the sequence across two dates, helping ensure consistent checks independent of local-time formatting. No user-facing behavior changes are included in this update.