test(webkit): wait for the DSM filter trigger to hydrate before pressing Enter

Merged
BI
1mo ago
+3-0

User description

Summary

  • Before: main's Safari release matrix after #3503 (run 38300091965) cleared the Forms test and showed one new intermittent failure. The installed-app (mobile-pwa-standalone) test "DSM category facets support keyboard selection and restore focus" focused the filter button and pressed Enter straight after load, before React had attached its handler. The filter panel never opened. The same test passed in the previous main run, which fits a timing race.

  • After: the test waits for the trigger to hydrate with the shared expectHydrated helper before focusing it. This is the same pattern as #3503.

  • Test-only. No test skipped, no assertion loosened, no app code changed.

Verification

  • Checks run: prettier --check ("All matched files use Prettier code style!") and eslint on the changed file, both clean.
  • WebKit can't run in this container, so main's next release browser matrix is the WebKit proof.

Risk and rollout

  • Risk: none to the app. This only changes test timing.
  • Rollback: revert this commit.
  • Provider or production effects: None.

Notes

  • Ledger: #9Z197J.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr

Generated by Claude Code

Summary by cubic

Fixes an intermittent WebKit failure in the DSM category facet test by waiting for the filter trigger to hydrate before pressing Enter.

Main's Safari matrix showed the installed-app test pressing Enter before React attached the trigger's handler, so the filter panel never opened. The test now uses the shared expectHydrated helper before focusing, matching the fix from #3503. Test-only change — no test skipped, no assertion loosened, no app code touched.

CodeAnt-AI Description

Stabilize keyboard selection in the DSM filter test

What Changed

  • The DSM category filter test now waits for the filter trigger to be ready before pressing Enter, preventing missed keypresses on slower browsers.

Impact

✅ Fewer intermittent WebKit test failures
✅ More reliable DSM keyboard-selection coverage

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.