test(webkit): wait for the Forms composer to be live before typing

Merged
BI
1mo ago
+24-15

User description

Summary

  • Before: main's Safari release matrix after #3502 had one failure left. The installed-app (mobile-pwa-standalone) test "keeps compact codes literal and uses the ordinary Forms result route" typed into the Forms home and pressed Enter straight after loading, before React had attached the composer's handlers. The search never submitted and the page stayed on the Forms home.

  • After: the test waits until the composer's change and submit handlers are attached, exactly as the Smart search test above it already did. That wait is now one shared helper used by both tests.

  • Both #3502 fixes passed on main (installed-app QTc and the phone Dictionary label); this is the only remaining release-matrix failure from main run 38291430591.

  • Test-only. No test skipped, no assertion loosened, no app code changed.

Verification

  • Checks run: prettier --check ("All matched files use Prettier code style!"), eslint and tsc --noEmit on the changed file, all clean.
  • WebKit cannot run in this container, so the WebKit proof is main's next release browser matrix. The PR's own browser jobs cover Chromium.

Risk and rollout

  • Risk: none to the app; test timing only.
  • Rollback: revert this commit.
  • Provider or production effects: None.

Notes

  • Ledger: #9Z197J.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr

Generated by Claude Code

Summary by cubic

Fixes a WebKit-only flake where the Forms installed-app test typed before React attached the composer's handlers, so the search never submitted.

Extracts the handler wait into a shared helper used by both the existing Smart search test and the Forms test. Test-only; no app code changed, no test skipped or loosened.

CodeAnt-AI Description

Stabilize the WebKit Forms search test

What Changed

  • The Forms search test now waits until typing and submitting are ready before entering a query, preventing lost input on slower browsers.
  • The Smart search tests use the same readiness check.

Impact

✅ Fewer intermittent WebKit Forms test failures

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.