chore: make CODEOWNERS resolvable and move it to .github/

YA
18d ago
+21-2

User description

What

Replace the unresolvable CODEOWNERS in this repository with one GitHub can actually enforce, and move it from the repository root to .github/CODEOWNERS.

Why

GET /repos/wave-av/api-spec/codeowners/errors on main currently reports 2 "Unknown owner" error(s) - every owner line in the existing file names a team that either does not exist in this organization or has no write access to this repository. GitHub silently ignores such lines, which means:

  • no reviewer is ever auto-requested on pull requests, and
  • any branch rule that requires Code Owner review can never be satisfied, because there is no code owner to give it.

That second point is the operational problem: a PR gated on Code Owner approval would sit unmergeable without an admin override.

Change

  • CODEOWNERS (root) -> .github/CODEOWNERS. GitHub checks .github/ first, then the root, then docs/; keeping a single file in the highest-precedence location avoids a stale shadow copy.
  • Default owner is the organization owner (@yakimoto), whose permission on this repository was verified via GET /repos/wave-av/api-spec/collaborators/yakimoto/permission -> admin. No organization team currently holds write on this repository, so a team handle would be ignored exactly like the old one. When a team is granted write here, swapping the handle is a one-line follow-up.
  • Explicit entries for the release-critical surfaces that exist in this repository (CI workflows, package manifest, release scripts, and the ownership file itself), so those paths keep an owner even if the default rule is later loosened.

Resulting file:

# CODEOWNERS - GitHub auto-requests review from the listed owners on matching paths.
# Every handle here must be a user or team with write access to this repository;
# an unresolvable handle is silently ignored and any "require Code Owner review"
# rule becomes unsatisfiable. Validate after editing:
#   gh api repos/wave-av/api-spec/codeowners/errors    # expect {"errors":[]}
# Later rules take precedence over earlier ones.

# Default owner for everything.
*                       @yakimoto

# Release-critical surfaces: CI/CD, package manifest, release tooling, ownership.
/.github/workflows/    @yakimoto
/package.json           @yakimoto
/.github/CODEOWNERS     @yakimoto

Verification

  • gh api repos/wave-av/api-spec/codeowners/errors?ref=chore/codeowners on this branch returns: {"errors":[]}
  • Head SHA: 4aa953dc77008a34ec452252bcf218e24149a952

Notes

  • GitHub Actions is currently billing-locked for this organization, so no workflow runs will appear on this PR; the CODEOWNERS validation above is done through the REST API, which does not depend on Actions.
  • This PR does not change branch protection or rulesets. It only makes the existing ownership file resolvable.
  • No secrets, tokens, or credentials are involved; the file contains a GitHub login and path globs only.

🤖 Generated with Claude Code

[!NOTE]
Low Risk
Documentation and GitHub review routing only; no application code, secrets, or branch protection changes in this PR.

Overview
Replaces broken repository ownership rules so GitHub can actually request reviewers instead of ignoring every line.

The root CODEOWNERS that pointed at @wave-av/core-team is removed and replaced with .github/CODEOWNERS, using @yakimoto as the default owner and explicit owners for /.github/workflows/, /package.json, /scripts/, and the ownership file itself. The new file documents validation via the codeowners errors API and warns not to enable mandatory Code Owner review until a second write-capable owner exists (single-maintainer limitation).

Reviewed by Cursor Bugbot for commit 6005be9d385b7ce6e324452a1b63684e68de7621. Bugbot is set up for automated code reviews on this repo. Configure here.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by Sourcery

Move and repair the repository’s CODEOWNERS configuration so GitHub can enforce code owner reviews.

Enhancements:

  • Replace the invalid root CODEOWNERS configuration with a resolvable .github/CODEOWNERS file that assigns ownership to verified repository owners and protects release-critical paths.

Chores:

  • Remove the obsolete root-level CODEOWNERS file.

CodeAnt-AI Description

Make GitHub code ownership requests work for this repository

What Changed

  • Replaces unresolved team owners with a repository maintainer who can receive review requests
  • Moves the ownership rules to .github/CODEOWNERS, where GitHub recognizes them
  • Adds explicit ownership for workflows, the package manifest, release scripts, and the ownership file
  • Documents how to validate the edited branch and why required Code Owner approval must wait until a second maintainer is available

Impact

✅ Working automatic review requests
✅ Enforceable ownership for release-critical files
✅ Fewer unresolvable Code Owner rules

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.