Optimize: session signals and judge inputs
Closed
UT
12d ago+592+592+012345678901234567890123456789-30-30-01234567890123456789
Description
Stacked on utkarshdalal/GameNative#2381. Adds session load signals the app sends to the server with each Optimize request and outcome, so the server can judge a change on more than average fps. No new card copy and no UI change.
- Sent in
perf_verdictongame_exited, in the request'sverdictblock and in outcomebefore/after:gpu_busy_p95,hot_thread_p95,fps_ceiling_reason,gpu_work_per_frame,gpu_work_by_5min,gpu_clock_by_5min,fps_by_5min,fps_p10,frame_time_p50_ms,frame_time_p99_ms,refresh_hz(also asdevice.refresh_hz) andstutter_share.judged_*funnel events carrygpu_work_per_frame_before,gpu_work_per_frame_after,gpu_busy_p95,hot_thread_p95andfps_ceiling_reason. - Hot thread: the thread with the most CPU time in the game process; wine, wineserver, dxvk, audio and binder helper threads are never picked, and processes named after the app package are never taken as the game.
- Probe cost: no new reads. The signals come from samples the per-second sampler already takes; nothing runs per frame and nothing runs inside the game.
Tests: signal math, lenient parsing of older runs and stored metrics, and the thread filter.
CI (stack check via draft utkarshdalal/GameNative#2386 against master): run 42596075264 on d8a7373, build (Modern) and build (Legacy) with unit tests passed.
Recording
None. No UI change.
Type of Change
- Bug fix
- Performance / stability improvement
- Compatibility improvements
- Other (requires prior approval)
Checklist
- If I have access to
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed. - This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
- I have attached a recording of the change.
- I have read and agree to the contribution guidelines in
CONTRIBUTING.md.