Gate live recovery test fixture to Unix targets

Merged
DU
2d ago
+1-0

Problem and behavior

Building test targets on Windows (e.g. cargo check --tests or cargo test --lib --no-run) fails with compiler errors E0433: cannot find UnixStream in net, cannot find UnixListener in net, and cannot find unix in os.

tests/unit/livekit/recovery.rs unconditionally declares mod live; pointing to recovery_live.rs. The offline parts and launcher fixture in recovery_live.rs rely on Unix domain sockets (tokio::net::UnixStream, tokio::net::UnixListener) and Unix permission extensions (std::os::unix::fs::PermissionsExt). On non-Unix platforms such as Windows, these symbols do not exist, preventing tests from compiling.

Approach

Add #[cfg(unix)] to the declaration of mod live; in tests/unit/livekit/recovery.rs. This allows test targets to compile cleanly on Windows without modifying the fixture itself or affecting Unix platforms where live recovery tests execute.

Validation

  • On Windows (x86_64-pc-windows-msvc), cargo check --tests failed on main (eee327b) with 3 E0433 errors and finishes cleanly with this change.
  • cargo test --test cli, cargo test --test config, and cargo test --test runtime continue to pass cleanly on Windows.
  • The change is strictly conditional (#[cfg(unix)]), ensuring Linux and macOS CI workflows retain identical test coverage.

Closes #771


Summary by cubic

Gates the live recovery test fixture to Unix targets so Windows test builds compile cleanly.

The fixture in tests/unit/livekit/recovery.rs relies on Unix domain sockets (UnixStream, UnixListener) and Unix permission extensions (PermissionsExt), which don't exist on Windows. cargo check --tests and cargo test --lib --no-run previously failed on Windows with E0433 errors; adding #[cfg(unix)] to the mod live; declaration fixes that while leaving Unix behavior and coverage unchanged.