Revert "refactor: derive hosts and display name from config (#8494)"
Merged
KI
1mo ago+165+165+012345678901234567890123456789-678-678-012345678901234567890123456789
Reverts #8494.
Two commits:
git revertof the #8494 squash commit. One conflict, inpackages/auth/src/server.ts, where #8354 rewrote the billing hooks. I kept main's version and undid only #8494's edits there.- #8354 already imports
NOREPLY_FROMandCOMPANY.SUPPORT_EMAILin four billing files. The revert removes both, so those files use the same literal strings as the rest of auth again (Superset <noreply@superset.sh>,support@superset.sh). The email text does not change.
Validation:
bun run lintandbun run check:i18npass.- auth, shared and email tests pass.
- Typecheck of auth, shared, email, trpc, cli, desktop, api, web, marketing, docs and mobile gives the same 165 errors on this branch and on
origin/main. They are the local better-auth inference errors and none is new. CI runs typecheck without them.
Summary by cubic
Reverts #8494, so hosts and the desktop display name are again hardcoded to superset.sh instead of being derived from NEXT_PUBLIC_ROOT_DOMAIN/EXPO_PUBLIC_ROOT_DOMAIN.
Refactors
- Drops the
app-identityandemail/senderhelpers and theROOT_DOMAIN,EMAIL_SENDING_DOMAIN, andRELAY_BACKUP_URLenv vars; deploy workflows no longer pass them. - Inlines
CANONICAL_URLSandCOMPANYconstants as literal URLs likehttps://app.superset.sh. - Desktop about panel, menus, and notifications use
app.name/productNameagain, and the localized{displayName}strings are removed. - Email from/to addresses are inlined as literals with no change to message content.
Summary by CodeRabbit
- Other Changes
- Standardized links, service addresses, and email contact details across the app, desktop client, mobile app, CLI, and emails to use Superset’s published domains.
- Desktop menus and notifications now use the app’s configured name.
- Removed support for customizing protected-cookie domains; protection now applies to Superset domains and local addresses.