refactor(marketing): drop the mobile-launch flag

Merged
SA
1mo ago
+42-167

Why

Mobile launched on September 21 and the mobile-launch flag has been on since. The marketing site still asked PostHog on every render whether to show /mobile. That read is also what stopped the sitemap from prerendering (#8128).

What changes

  • /mobile is always in the header and footer nav, always in the sitemap, and always indexable.
  • Removed site-flags.ts, the server PostHog client, MobileLaunchProvider and the posthog-node dependency from marketing.
  • The desktop app still reads the same flag; it is not touched.

Behaviour change

If PostHog was unreachable, the site used to hide the Mobile link and mark /mobile as noindex for up to a minute. That fallback is gone.

Verified locally

  • Build passes; /sitemap.xml and /mobile are static.
  • Typecheck and the marketing tests pass, with the sitemap test updated.

Not verified

  • I did not click through the nav on a running build.

Summary by cubic

Drops the mobile-launch feature flag from the marketing site now that mobile has launched. /mobile is always in the header and footer nav, always in the sitemap, and always indexable; the flag reader, MobileLaunchProvider, the server PostHog client, and the posthog-node dependency are removed.

Behavior change

  • Previously, if PostHog was unreachable, the site hid the Mobile link and marked /mobile as noindex for up to a minute. That fallback is gone.
  • The desktop app still reads the same flag and is not affected.

Summary by CodeRabbit

  • Updates
    • The Mobile link now appears in the site footer and Product menus regardless of launch status.
    • The Mobile page is now included in the sitemap for all visitors and languages.
    • Search engines can index the Mobile page, and its App Store description is displayed regardless of launch status.