fix(desktop): line up the cloud row's PR button and status

Merged
SA
1mo ago
+14-18

The cloud sidebar row's right cluster used fixed 20px slots, ml-5, pr-4 and a -mr-[6.25px] nudge on the delete X, so the PR icon sat 3px from the time and drifted between rows.

  • Local-row spacing: gap-1.5, pr-2, bare 14px X (8px from the edge, same as local rows).
  • Status sits in a 24px right-aligned column, so PR icons line up across rows.
  • Owner avatar 20px → 18px.

Variants compared: https://app.superset.sh/page/cloud-row-variants-3qrfx0

Verified in Storybook (DashboardSidebarCloudRow Section story): PR icons at the same x in both rows, status column 24px / 8px inset, avatar 18px, hover X 14px / 8px inset. Not checked in the running app.

Summary by cubic

Fixes the cloud sidebar row's PR button and status so they line up across rows; previously the right cluster's fixed 20px slots, ml-5, pr-4, and a -6.25px margin nudge left the PR icon 3px off from the time and drifting between rows.

  • Replaces those fixed slots with the local row spacing (gap-1.5, pr-2, bare 14px delete X) so the hover X sits 8px from the edge.
  • Moves the status into a 24px right-aligned column so PR icons align across rows.
  • Shrinks the owner avatar from 20px to 18px.