fix(desktop): terminal page links follow the URL link rules

Merged
SA
1mo ago
+37-62

Problem

Page links in the terminal opened on a plain click, even when Settings → Links → URL links says a plain click does nothing. Since #7471, a page link skipped the URL modifier rules entirely and used the single Pages action (default: split pane) for every click.

Change

  • Terminal page links now go through the URL link rules like any other URL — plain / ⇧ / ⌘ / ⌘⇧ click each do what the URL rules say. When a rule opens the link in-app (split pane / new tab), runUrlLinkAction still opens the page pane, not a web view. The hover label follows the same path.
  • The Pages setting is now read only by the workspace Pages menu, so its description (and settings-search text) says that. The old text also mentioned chat and task markdown, which never read it. Translations updated for all 16 locales.

Trade-off

You can no longer send ordinary URLs to the browser on ⌘-click while keeping page links in-app on the same modifier — the case #7471 was built for. Pick different modifiers for each instead (e.g. ⌘ → browser, ⌘⇧ → split pane).

Validation

  • bun run lint, desktop typecheck, bun run check:i18n, desktop renderer tests (6,286 pass) — green locally.
  • Not yet clicked through in a running app.

Summary by cubic

Terminal page links now follow the URL link rules instead of always using the Pages action on any click.

Bug Fixes

  • Plain, ⇧, ⌘, and ⌘⇧ clicks each do what the URL rules say; when an in-app action applies, the page pane opens rather than a web view, and the hover label follows the same path.
  • The Pages setting now only applies to the workspace's Pages menu, so its description and translations were updated.
  • Trade-off: you can no longer use ⌘-click to send URLs to the browser while keeping page links in-app on the same modifier — pick different modifiers instead (e.g., ⌘ → browser, ⌘⇧ → split pane).

Summary by CodeRabbit

  • Behavior
    • Terminal URL clicks and hover labels now follow the same URL-handling policy, including for Superset pages.
  • Settings
    • Clarified that the Pages setting controls where pages opened from a workspace’s Pages menu appear.
  • Localization
    • Updated the setting description across supported languages.