feat(desktop): organize browser and file editor settings

Merged
KI
1mo ago
+790-665

What & why

File and browser preferences were split between General and Links, and the click-action rows were difficult to scan. Group them by the surface they control:

  • Replace Links with Files & Editor, organized into Editing, Opening files, and Opening folders. Move Auto Save and the legacy file-open mode from General.
  • Consolidate URL, port, Page, and legacy in-app browser behavior under Browser, alongside its homepage and import settings.
  • Use the bordered, divided rows already present in Keyboard and Appearance, with wider selectors that show the full action label.
  • Update sidebar navigation, command-palette entries, Settings search, and all translations. Preserve saved preference keys and redirect /settings/links to /settings/files.

How I tested it

Actual app screenshots and detailed evidence

  • Passed bun run lint, bun run typecheck (42 tasks), bun run check:i18n, and bun run check:plugins.
  • Passed all 18 settings-search tests, including updated Auto Save section expectations.
  • Drove this worktree's Electron app over CDP: opened Files & Editor, Browser, and General; searched for Auto Save; changed Auto Save to After delay, navigated away and back to confirm persistence, then restored Off; confirmed a fresh load of the old Links URL redirects.
  • bun run test failed with 34 desktop Git/worktree and shell-environment test failures. Examples include empty Git rev-parse output during fixture setup and missing shell environment variables. These areas are outside this change. The full suite is not claimed to pass.
  • V1 rendering and actual file-saving behavior were not tested.

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on fork PRs (same-repository branch)

Summary by cubic

Groups desktop settings by the surface they control. Replaces the Links page with Files & Editor and moves browser-related preferences under Browser.

Behavior changes

  • Auto Save and file-open mode moved from General to Files & Editor.
  • URL, port, and Page click behavior plus the in-app browser toggle now live under Browser.
  • /settings/links redirects to /settings/files; saved preference keys are unchanged.

Refactors

  • Rows now use the bordered divided style from Keyboard and Appearance, with wider selectors.
  • Updated sidebar navigation, command palette entries, settings search, and all translations.

Summary by CodeRabbit

  • New Features
    • Added a “Files & Editor” settings section with controls for auto-save, file and folder opening behavior, and link handling.
    • Added browser settings for opening links in the in-app browser and configuring how URL, port, and page links open.
  • Updates
    • Moved link-related settings from the separate Links section into Files & Editor and Browser settings. The previous Links route now redirects to Files & Editor.
    • Refined the appearance and layout of link-handling controls.