feat(mobile): full-height workspace sheet with a PR section, no Delete

Merged
SA
2mo ago
+71-62

Summary

  • The workspace sheet opens at the full detent (sheetAllowedDetents: [1.0], was [0.65, 1.0]). The grabber and drag-to-dismiss still work.
  • Removes the Delete workspace button from the sheet, plus its handler in useWorkspaceHeaderActions, which had no other caller. useDeleteWorkspace is untouched and still backs the home row's delete.
  • Adds a PR section between Info and Pages. It lists every PR the workspace has been linked to (useWorkspacePullRequests, current first), with the same status glyphs as the home list and the Pull Requests sheet. Tapping a row opens the PR through openUrl. With no PRs the section is hidden.

Verification

Ran this branch's JS on the iPhone 17 Pro Max simulator (iOS 26) against production with real workspaces. Screenshots: https://app.superset.sh/page/workspace-sheet-pr-section-wt1y5g

  • One open PR: full-height sheet, title wraps to two lines with a muted #7776
  • Four-PR history: open is green, merged is purple
  • A workspace with no PR: section hidden
  • Tapping a row with Maestro opened the PR on github.com

Not checked: other locales, large text sizes, an offline host.

Known follow-up

When a title fills both lines, the ellipsis cuts off the trailing #number. The fix is to give the number its own non-truncating slot.

Summary by cubic

The workspace sheet now opens at full height, drops the Delete button, and gains a PR section listing linked pull requests.

  • The sheet opens at the full detent (was a partial height) with the grabber and drag-to-dismiss still working.
  • The Delete workspace button and its handler in useWorkspaceHeaderActions are removed; useDeleteWorkspace still backs the home row's delete.
  • A PR section between Info and Pages lists linked pull requests (newest first) with the same status glyphs as the home list; tapping a row opens the PR, and the section is hidden when there are none.
  • PR rows now carry an accessibility label so VoiceOver announces their title instead of just the number.

Summary by CodeRabbit

  • New Features
    • Workspace action sheets show the workspace’s pull requests, including their status and number. Tap a pull request to open it.
  • Updates
    • The workspace action sheet opens at full height.
    • The “Delete workspace” action is no longer available in the workspace action sheet.