feat(desktop): show pull request comments below the description
Merged
KI
2mo ago+1113+1113+0123456789012345678901234567890123456789-480-480-012345678901234567890123456789
What & why
Show review and conversation comments below the PR description in the workspace pull request pane. Comments use a flat layout with full Markdown, shared with the existing comment pane, and retain copy, GitHub, resolve, and open-comment actions. File and line links open the corresponding code pane on the correct diff side. All thread replies are included, with individual GitHub links. Resolved comments are collapsible, and the empty state only appears when no comments exist.
Reuse comment normalization and base-aware diff navigation with the review sidebar. The existing description, checks, and merge setup remain available.
How I tested it
- All 3,785 desktop tests pass, including full comment-body rendering and comment navigation on both diff sides.
- Repository typecheck and lint, i18n checks, and plugin checks pass.
- Verified in the running Electron app through CDP: comments below the description, file links opening the correct code and thread, split-pane layout, and no horizontal overflow.
- Real-app CDP screenshots.
- Full repository tests stop in
@superset/trpcbecause required environment variables are missing locally; 273 tests in that package passed before the environment error.
Checklist
- PR title follows conventional commits (
type(scope): subject) -
bun run lintandbun run typecheckpass - "Allow edits from maintainers" is checked on fork PRs (same-repository PR)
Summary by CodeRabbit
-
New Features
- Added rich Markdown rendering for pull request comments, including copyable tables and Mermaid diagrams.
- Added pull request comment cards with author details, status badges, copy, GitHub, comment-pane, and diff navigation actions.
- Added comment resolution and unresolution controls.
- Review comments now include replies and link directly to their GitHub discussions.
- Improved navigation between comments, files, and diff views.
-
Bug Fixes
- Resolved comments remain visible when all comments are resolved.
- Comment navigation now opens the correct diff side and location.