fix(desktop): restore active pane border

Merged
KI
3mo ago
+5-1

What & why

Restore the active-pane border removed in #6777. The highlight only appears when a tab has two or more panes, so a solo pane remains borderless.

How I tested it

  • bun run --filter @superset/panes typecheck
  • bun run --filter @superset/panes test (100 passing)
  • CDP on the real desktop renderer: opened a single terminal pane and confirmed its 2px border is transparent; used the visible Split pane control and confirmed the inactive pane remains transparent while the active pane uses border-primary/15.

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (package-scoped typecheck passed; CI will run the full checks)
  • "Allow edits from maintainers" is checked on fork PRs (not a fork PR)

Summary by cubic

Restores the active-pane border in the desktop renderer to make focus obvious in split views. Previously panes had no border; now only the active pane in a split shows a subtle 2px border, while single-pane tabs remain borderless.

  • Review notes: Change is localized to packages/panes (@superset/panes). Pane.tsx always renders a 2px border and toggles color to border-primary/15 when the pane is active and the tab is split; otherwise it stays border-transparent to avoid layout shift. Validate by splitting a tab: only the active pane should show the border; inactive and single-pane states should remain borderless.

Summary by CodeRabbit

  • Style
    • Improved the active pane’s appearance in split layouts with a border and partial highlight.
    • Added a smooth color transition when pane states change.
    • Preserved the transparent border for inactive panes.