fix(mobile): move home search in-page — iOS 26 header search bar swallows all touches

Merged
SA
3mo ago
+37-19

What

Search results on mobile home couldn't be tapped, and active search couldn't be dismissed. This replaces the native header Stack.SearchBar with an in-page search field (the BranchPickerScreen pattern) in the home list header. Filtering logic is unchanged.

Why

Reproduced end-to-end on an iOS 26.0 simulator against a local stack: while the UISearchController is active, an invisible native view covers the screen content and eats every touch — instrumented onTouchStart on the list never fired during search, and fired normally once dismissed. Nothing reaches RN, so rows are dead and search feels stuck (only the tiny X escapes).

Tried and failed: obscureBackground={false}, hideNavigationBar both ways, placement variants. No upstream fix through react-native-screens 4.27 / iOS 26.5; adjacent known iOS 26 search regressions: rns #3270 (back nav breaks after search), Apple FB17888632 (stacked search steals touches), rns #3621 (zoom transition blocks touches). The native header search bar is not shippable on iOS 26.

How

  • In-page Input + magnifier glyph as the LegendList header above the scope chips (visually near-identical to the native bar), clearButtonMode="always", returnKeyType="search", autocapitalize/autocorrect off
  • keyboardShouldPersistTaps="handled" + keyboardDismissMode="on-drag" on the list
  • Removed the now-unused Stack/THEME imports

Verified

On-device (iPhone Air sim, iOS 26.0, local API/relay/host-service + seeded workspaces): type → list filters live with result count; tap result → workspace opens; back → query retained; clear (x) → full list restores; scroll drops the keyboard.

Known wrinkle (pre-existing, unchanged): with the keyboard up, the first tap on a row dismisses the keyboard and the second opens it — the rows' native Link.Trigger context-menu wrapper takes the first touch outside RN's control.

Checks: lint:fix clean, typecheck clean, sherif clean. bun test: 175 local failures on this branch vs 178 on clean HEAD — identical failure set (zero unique to this change), all pre-existing local-env noise (pty/git/relay suites).

https://claude.ai/code/session_01JMrgzD2hPpB89caKAxR7ux


Summary by cubic

Moves home search from the native header to an in-page field to restore tap interactions on iOS 26. Old: Stack.SearchBar (UISearchController) swallowed all touches while active; results couldn’t be tapped and search couldn’t dismiss. New: an in-page Input in the list header; taps work, keyboard dismisses on drag, and filtering logic is unchanged.

  • Review notes

    • HomeScreen.tsx: remove header Stack.SearchBar; add listHeader with Input + Search icon above scope chips; set keyboardShouldPersistTaps="handled" and keyboardDismissMode="on-drag".
    • Visual parity with the native bar; clear button always visible. Known pre-existing quirk remains: first tap with keyboard up dismisses it; second opens the row.
  • Rollout

    • No migration required. Focus testing on iOS 26 tap-through and keyboard behavior; quick smoke on Android/earlier iOS.

Summary by CodeRabbit

  • New Features

    • Added an in-page search field to the home screen.
    • Added a scope bar alongside the search field for easier browsing.
  • Improvements

    • Improved touch handling and keyboard dismissal while interacting with the home list.