fix(desktop): stop new-workspace suggestions overlapping the heading

Merged
SA
3mo ago
+6-2

The suggestion cards render straight through the "What should we build next?" heading:

cards overlapping the heading

Cause

The suggestion block is positioned absolute inset-x-6 bottom-full, so it takes no layout space. The heading above it is the flex-1 spacer — it centers itself into whatever room is left, which includes the room the suggestions then draw on top of.

Latent since the screen shipped in #5907; it just needed a tall enough suggestion set to surface. The returning-tier explain-superset card wrapped its title to two lines, which was enough.

Fix

Put the block back in flow. The flex-1 heading absorbs its height, so nothing overlaps at any window height.

The composer does not move as a result: the composer block is bottom-anchored by pb-8 and PromptInput sits below the suggestions inside it, so only the heading recenters. On typing, the suggestions unmount and the heading drifts back down. The root is already overflow-y-auto, so a window too short for both scrolls rather than collides.

Also shortens the explain-superset label to "Get more out of Superset" — one line instead of two, better copy, and it keeps the block shorter regardless of the layout fix.

Verification

bun run typecheck and ./scripts/lint.sh pass. Not visually confirmed in the running app yet — flagging that explicitly rather than implying otherwise. Worth an eyeball on all three arms (control / cards2 / cards4) before this is relied on, since cards4 is the tallest case.

Summary by cubic

Prevents new-workspace suggestion cards from overlapping the "What should we build next?" heading. Previously the suggestions were absolutely positioned and drew over the heading; now the suggestions are in normal flow, so the heading absorbs their height and the composer stays bottom-anchored.

  • Verify layout across prompt card variants (control, cards2, cards4) at various window heights; PromptInput position should be unchanged and the root should scroll when space is tight.
  • Copy tweak: the explain-superset card label is shortened to "Get more out of Superset" to reduce card height.

Summary by CodeRabbit

  • Bug Fixes
    • Sample prompt suggestions now display in normal flow, preventing taller lists from overlapping the heading.
  • UI Updates
    • Shortened the Superset sample prompt label to “Get more out of Superset.”