chore(host-service,host-client,desktop): delete ACP sessions stack

Merged
SA
3mo ago
+961-9380

Teardown Wave A, slice 2

Deletes the ACP sessions stack. ACP is dropped in favor of chat-v3: it was gated behind SUPERSET_ACP_SESSIONS=1 (internal builds only), its mobile-only UI was already removed in #6366, it has zero stable-build users, and it emitted zero analytics.

Removed

  • host-service ACP runtime (src/runtime/acp-sessions/) + router + /acp-sessions/* WS route + the env gate and disposal wiring in app.ts
  • acp_sessions host.db table (migration 0022, generated via host-service's own drizzle setup)
  • packages/session-protocol/ entirely (18 files) — HarnessKind/StopReason needed no inlining, acp_sessions was their only consumer
  • host-client's ACP arm (src/acp/, the ./acp export); the package itself stays
  • @agentclientprotocol/sdk + @agentclientprotocol/claude-agent-acp deps (host-service, desktop)
  • SUPERSET_ACP_SESSIONS wiring in the desktop host-service coordinator
  • 6 ACP integration tests + their fake-adapter fixture, docs/acp-sessions.md

Retired: plans/acp-session-follow-ups.md and plans/acp-host-client-unification.md move to plans/done/ — both were on a "keep and improve" track; nothing new should be built on them.

Net: −9,380 lines.

Verification: lint exit 0 · typecheck exit 0 (37/37) · host-client 8/8 · host-service 1067 pass / 1 fail, and that failure (EventBus fs:watch-file pruned-path) reproduces on a clean tree — pre-existing and unrelated · sherif exit 0. Residual grep hits are stale gitignored dist-types/ build output only.

Follow-ups this exposes (not in scope): isInternalBuild() now has zero callers; @superset/host-client now has no consumers in the monorepo; plans/host-integration-test.md cites the deleted ACP tests and is stale.

Part of the Sandbox Workspaces cleanup track.

Summary by cubic

Removes the ACP sessions stack and its gate in favor of chat‑v3. Previously, internal builds could enable ACP with SUPERSET_ACP_SESSIONS; now the ACP router, WS stream, client surface, and DB table are gone, and dependencies on ACP libraries are removed.

  • Drops the host-service ACP runtime, tRPC router acpSessions.*, and /acp-sessions/:id/stream.
  • Removes SUPERSET_ACP_SESSIONS wiring from desktop and the host service.
  • Adds migration 0022 to drop the acp_sessions table.
  • Deletes packages/session-protocol and removes @agentclientprotocol/sdk and @agentclientprotocol/claude-agent-acp from host-service and desktop.
  • Removes the @superset/host-client ACP entrypoint (./acp) and related tests/docs; plan docs move to plans/done/.

Migration

  • Run host-service DB migrations to apply 0022 (drops acp_sessions).
  • Remove any imports from @superset/session-protocol.
  • Stop importing @superset/host-client/acp and calls to acpSessions.*; migrate any remaining ACP usage to chat‑v3 surfaces.

Summary by CodeRabbit

  • Removed Features

    • Removed ACP session support, including session management, streaming, persistence, APIs, and related client integrations.
    • Removed ACP session React hooks and shared session-protocol exports.
    • Existing workspace transport functionality remains available.

  • Chores

    • Removed obsolete ACP-related packages, dependencies, database records, and configuration.

  • Documentation

    • Removed outdated ACP session documentation.