fix(desktop): remove empty top strip on automations, tasks, and workspaces views

Merged
AV
3mo ago
+27-3

Summary

  • On the v2 dashboard with the expanded sidebar, the TopBar rendered as a completely empty 48px strip above the Automations, Tasks, and Workspaces views. It's now hidden there, so each view's header sits flush with the window top.

Why / Context

When the expanded v2 sidebar sits outside the TopBar column, the sidebar header already hosts the traffic-light pad, sidebar toggle, and nav controls — leaving the TopBar with nothing to show on these routes. The workspace detail and new-workspace routes already hid it; these three views were the remaining places showing the dead strip.

How It Works

  • _dashboard/layout.tsx extends hideTopBar to /automations, /tasks, and /v2-workspaces (fuzzy, so detail pages match too), gated on sidebarOutsideColumn. With the sidebar collapsed or closed the TopBar still renders, since it then carries the toggle, nav controls, and traffic-light inset.
  • Each affected header (Automations list + detail, Tasks top bar + task/issue/PR detail, Workspaces) gains an empty drag filler leaf so the window stays draggable across the top, following the drag-on-empty-leaves rule.

Manual QA Checklist

Verified end-to-end over CDP against the dev app (signed-in session, expanded v2 sidebar), navigating by real clicks on the sidebar buttons:

  • Automations: header renders at window top, no 48px bar in the DOM
  • Tasks: TasksTopBar renders at window top
  • Workspaces: header h1 at top, no bar
  • Baseline (pre-fix boot state) showed the empty TopBar strip above these views
  • Collapsed/closed sidebar still shows the TopBar with toggle + nav (code-path only, not exercised live)
  • Window dragging from the header filler areas (drag regions can't be exercised via CDP)

Testing

  • bun run lint
  • bun run typecheck (desktop)

https://claude.ai/code/session_015PEPRDMRZobovARaZiBHgd

Open in Stage

Summary by cubic

Fixes an empty 48px top strip on Automations, Tasks, and Workspaces in the v2 desktop dashboard. The TopBar is now hidden on these routes when the expanded sidebar hosts the window controls, so headers sit flush with the top.

  • Bug Fixes
    • Hide TopBar on /automations, /tasks, and /v2-workspaces (fuzzy) when sidebarOutsideColumn is true.
    • Keep TopBar when the sidebar is collapsed or closed to show the toggle, nav, and traffic-light inset.
    • Add drag filler elements to each view header to keep the window draggable.

Summary by CodeRabbit

  • UI Improvements
    • Improved window dragging across automation, task, issue, pull request, and workspace views.
    • Updated dashboard layouts to provide consistent draggable header areas when the top bar is hidden.
    • Preserved existing header actions, search, filters, navigation, and workspace controls.