fix(desktop): remove browser pane tooltips and restyle pane/preset tooltips
Merged
AV
4mo ago+106+106+012345678901234567890123456789-140-140-012345678901234567890123456789
Summary
- Remove tooltips from the browser pane's back, forward, and reload buttons (both the v1 and v2 workspace copies of
BrowserToolbar) - Remove the close-pane tooltip from the shared pane header actions: v1
PaneToolbarActionsand v2useDefaultPaneActions(madetooltipoptional in@superset/panesPaneActionConfigand render a plain button when absent) - Drop the now-dead
closeHotkeyIdprop fromPaneToolbarActionsand its five call sites - Restyle the "Manage Presets" and split-pane tooltips to the subtle hotkey-chip style (bordered
bg-background, no arrow) with a 1s hover delay, matching the preset-itemHotkeyTooltips
Test Plan
-
bun run lintpasses -
turbo typecheckpasses for@superset/desktopand@superset/panes - Hover browser back/forward/reload and close-pane buttons — no tooltips
- Hover the presets cog and split-pane buttons — chip-style tooltip appears after ~1s
https://claude.ai/code/session_01CxPkcBBWZeaNygsF9dwMCH
Summary by cubic
Removed tooltips from browser pane navigation and close actions, and restyled split-pane and “Manage Presets” tooltips to a subtle hotkey-chip style with a 1s hover delay.
- Refactors
- Made
tooltipoptional in@superset/panesPaneActionConfigand render a plain button when absent. - Removed
closeHotkeyIdfrom desktopPaneToolbarActionsand all call sites.
- Made
Summary by CodeRabbit
- UI Improvements
- Updated preset and pane-action tooltips with a consistent appearance, positioning, and one-second delay.
- Removed tooltips from browser navigation and reload controls for a cleaner toolbar.
- Removed close-pane hotkey hints from pane controls while preserving close functionality.
- Improved toolbar behavior for actions without tooltips, preventing unnecessary tooltip containers.