fix(ci): chain Homebrew formula bump into release-cli pipeline

Merged
SA
6mo ago
+38-11

Problem

The Homebrew tap formula has been stuck at 0.2.7 while the CLI shipped through 0.2.19 — brew install superset gives users a months-old build.

bump-homebrew.yml triggered on on: release: [published]. But the v0.2.11 commit (0fcec53ff) dropped --draft from release-cli.yml so the per-version release auto-publishes. The catch: that publish now happens via the workflow's GITHUB_TOKEN, and GitHub deliberately does not fire workflow triggers for events generated by GITHUB_TOKEN (anti-recursion safeguard; only workflow_dispatch/repository_dispatch are exempt).

Timeline that matches the symptom exactly:

  • ≤ 0.2.7 — --draft, published manually in the UI → human published event → bump ran ✅
  • 0.2.8–0.2.10 — still --draft, never manually published → sat as drafts → no event → no bump
  • 0.2.11+ — --draft dropped, auto-published by GITHUB_TOKEN → trigger suppressed → no bump ❌

(Corroboration: desktop-v* releases still fire bump-homebrew — it runs and skips on the tag filter — because desktop keeps --draft and is published by a human.)

Fix

Stop depending on the cross-workflow release: published event entirely:

  • bump-homebrew.yml → reusable workflow (workflow_call + workflow_dispatch, validated tag input). Render/SHA/push logic unchanged.
  • release-cli.yml → calls it as a needs: release job (uses: + secrets: inherit), so the bump runs in the same workflow run. Deterministic, immune to the GITHUB_TOKEN rule.

workflow_dispatch also lets anyone re-bump a specific tag by hand.

Out of band

The tap was already manually bumped to 0.2.19 (superset-sh/homebrew-tap@b7823a2) so brew users are unstuck today. This PR prevents the drift from recurring.


Open in Stage

Summary by cubic

Chains the Homebrew formula bump into the release-cli workflow so every cli-v* release updates the tap. Removes reliance on release: published, which doesn’t fire for GITHUB_TOKEN releases.

  • Bug Fixes
    • Converted .github/workflows/bump-homebrew.yml to a reusable workflow with workflow_call and workflow_dispatch (tag input).
    • Invoked it from .github/workflows/release-cli.yml as a needs: release job with secrets: inherit, ensuring the bump runs after assets publish.
    • Added manual workflow_dispatch to re-bump any tag when needed.

Summary by CodeRabbit

  • Chores
    • Improved CLI release automation by integrating the Homebrew formula update directly into the release workflow for streamlined publishing.

Review Change Stack