[codex] Fix changes sidebar modifier click behavior

Merged
KI
6mo ago
+373-35

Summary

  • Add a centralized changes-sidebar click policy that translates the existing sidebar file-link settings into changes-specific intents.
  • Update grouped and tree changes rows so Cmd/Ctrl-click opens the actual file pane, while Cmd/Ctrl-Shift-click opens the external editor.
  • Update sidebar file-link defaults and read-time preference healing so users on the old default get the corrected Cmd/Ctrl behavior without losing custom mappings.

Impact

Plain clicks still open diffs, Shift-click still opens diffs in a new tab, and existing settings remain the source of truth for modifier behavior. Menu shortcut labels and hover hints now come from the same centralized policy.

Validation

  • bun test apps/desktop/src/renderer/lib/clickPolicy/policies/changesSidebarFilePolicy.test.ts apps/desktop/src/renderer/routes/_authenticated/providers/CollectionsProvider/dashboardSidebarLocal/schema.test.ts
  • bun run typecheck --filter=@superset/desktop
  • bun run lint:fix
  • bun run lint
  • git diff --check

Open in Stage

Summary by cubic

Centralized the changes sidebar click policy and updated the tree and row components to use it. Hover hints and menu shortcuts now come from one source, and unbound tiers are respected.

  • Bug Fixes

    • Plain click opens the diff. Shift-click opens the diff in a new tab.
    • Cmd/Ctrl-click opens the file pane. Cmd/Ctrl-Shift-click opens the external editor.
    • Unbound modifier tiers do nothing.
  • Migration

    • Auto-heals legacy sidebarFileLinks defaults to the new default (meta: pane, metaShift: external) without changing custom mappings.

Summary by CodeRabbit

  • New Features

    • Enhanced changes sidebar click routing: modifier keys (Shift, Cmd/Ctrl) now control opening diffs, files, or external editor; keyboard shortcut hints updated.
  • Chores

    • Changed default action for one modifier to open in-pane instead of external editor.
    • Centralized and improved click-intent resolution across the changes sidebar.
  • Tests

    • Added unit tests covering intent resolution and tier mappings.

Review Change Stack