[codex] warn before relay toggle restarts host service

Merged
KI
6mo ago
+44-37

Summary

Warn before changing the relay exposure setting in either direction, because the setting mutation restarts active host-service instances and stops running terminals.

Changes

  • Route both enable and disable switch actions through the relay confirmation dialog.
  • Pass the intended target state into the dialog so the copy and action label match the direction.
  • Use destructive confirmation actions for both directions, labeled Enable and restart or Disable and restart.
  • Keep the stronger typed confirmation for enabling relay access.

Impact

Users now see that changing Relay access restarts the host service, stops running terminals, and interrupts file watches or other host-backed work before the setting is applied.

Validation

  • bunx @biomejs/biome@2.4.2 check --write --unsafe apps/desktop/src/renderer/routes/_authenticated/settings/security/components/SecuritySettings/SecuritySettings.tsx apps/desktop/src/renderer/routes/_authenticated/settings/security/components/SecuritySettings/components/ExposeViaRelayConfirmDialog/ExposeViaRelayConfirmDialog.tsx
  • bun run --cwd apps/desktop typecheck

Summary by cubic

Show a confirmation before enabling or disabling Superset Relay access, warning that the change restarts the host service, kills running terminals, and interrupts file watches and other host-backed work. Enabling still requires typing "I understand"; disabling only needs a simple confirm.

  • New Features
    • Route both enable and disable through a single confirm dialog that knows the target state.
    • Action labels now read "Enable and restart" or "Disable and restart"; dialog copy trimmed to focus on the access change and restart.

Summary by CodeRabbit

Bug Fixes

  • Confirmation dialog now appears for both enabling and disabling relay access to ensure deliberate changes.
  • Enabling requires typing the confirmation phrase; disabling is simplified (no typed confirmation).
  • Dialog titles, descriptions, and confirm button labels/appearance update to reflect whether you are enabling or disabling.