chore: run the action on node24, refresh v12 backlog

Merged
SR
3mo ago
+20-9

Post-v11 cleanup

Small follow-ups found by checking the shipped state against the repo. No user-facing behavior change.

Action runs on node24

Both manifests declared using: "node20". GitHub already force-migrates node20 actions and warns on every run:

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24

The bundle targets node22+, so node24 is pinned explicitly in action.yml and packages/action/action.yml. Verified against the docs that node24 is a supported runs.using value, and smoke-tested the built bundle end-to-end on a modern runtime:

exit: 0
✅ Minification complete! 31.3% reduction in 9ms
var g=function(n){return"hi "+n};

The composite action at .github/actions/node-minify/action.yml is using: composite and unaffected.

v12 backlog corrected

It had drifted from the code it describes:

  • Item 1 listed deprecated type-alias detection as outstanding, but v11 shipped it — along with @node-minify/run and engines.node scanners. Only the GCC runtime guidance remains.
  • It stated the compressor registry carries the GCC caveat via a notes field. CompressorEntry has only name, status, packageName and optional replacement — there is no notes field, so a v12 implementer would have gone looking for something that doesn't exist.
  • Post-release ops listed all 5 removed compressors as pending npm deprecation. Checked the registry: all 5 are already deprecated with replacement messages. Only @node-minify/run is still undeprecated.

Also recorded the two release traps this cycle exposed, so they aren't rediscovered at v12:

  • GITHUB_TOKEN cannot create a tag whose tree adds .github/workflows/*, so the major tag needed a manual push
  • scripts/publish.ts catches every npm publish error as "may already exist" and exits 0 — a real failure is indistinguishable from a no-op

Verification

GateResult
buildpass
lint / typecheckpass
test1047 passed (70 files)
removed-compressor guardpass
action manifests parse, using=node24pass
action bundle minifies end-to-endpass

Needs your npm credentials

@node-minify/run was removed in v11 but still installs silently at 10.5.0. I'm not authenticated to npm locally, so this one is yours:

npm deprecate @node-minify/run "@node-minify/run was removed in v11. It was an internal Java/process-spawn helper with no public replacement; remove it from your dependencies."

Summary by cubic

Pins the GitHub action to node24 in both manifests and corrects the v12 backlog doc to match what v11 actually shipped.

  • GitHub force-migrates node20 actions to node24 with warnings on every run; the bundle already targets node22+, so this removes the warnings.
  • The backlog wrongly listed deprecated type-alias detection as outstanding (v11 shipped it), claimed a notes field that doesn't exist on CompressorEntry, and listed all 5 removed compressors as pending deprecation when only @node-minify/run remains.
  • Records two release traps for v12: GITHUB_TOKEN can't create a tag that adds workflow files, and scripts/publish.ts logs publish failures but exits 0, so CI can't distinguish a real failure from a no-op.

@node-minify/run still installs silently at 10.5.0; deprecating it requires npm credentials.

Summary by CodeRabbit

  • Updates
    • Upgraded the GitHub Action runtime from Node.js 20 to Node.js 24.
  • Documentation
    • Updated the v12 backlog to reflect completed v11 work and current release-operation items.