fix(ci): build all workspace deps before bundling the action
Fix the failed v11.0.0 action release
npm publishing succeeded — all 22 packages are live at 11.0.0 — but the newly-wired action release step failed on its first ever run (run 33636966534).
Cause
release-action.yml built only two workspace packages:
bun run build:deps # utils
bun run --filter '@node-minify/core' build # core
But packages/action bundles seven: benchmark, core, esbuild, oxc, swc, terser, utils. So bun build could not resolve the rest:
error: Could not resolve: "@node-minify/benchmark"
at packages/action/src/benchmark.ts:8:27
error: script "build" exited with code 1
This was pre-existing — the workflow had never run before, so it had never been exercised.
Fix
Use the root build script, which already handles ordering: utils first, then everything except the action in parallel, then the action last.
Verified from a clean packages/action/dist: build exits 0, dist/index.js is produced, and the bundle resolves benchmark.
Consequence
v11.0.0 published to npm but no v11 / v11.0.0 git tag exists, so uses: srod/node-minify@v11 still does not resolve. After this merges, re-run the workflow to create the tags:
gh workflow run release-action.yml -f tag=v11.0.0
The authorization guard added in #2905 permits this: v11.0.0 is a published, non-draft release.
Verification
| Gate | Result |
|---|---|
| clean rebuild → action bundle | pass |
| lint / typecheck | pass |
| test | 1047 passed (70 files) |
| removed-compressor guard | pass |
| YAML parse | pass |
Summary by cubic
Fixes the v11.0.0 action release failure by building all workspace packages before bundling the action.
The release workflow previously built only utils and core, but the action bundles seven workspace packages, so bun build could not resolve @node-minify/benchmark. The root build script already handles the correct order — utils first, then the other packages in parallel, then the action last — so the workflow now uses it instead of manually building two packages. Verified that the bundle is produced and resolves benchmark from a clean packages/action/dist. Note that v11.0.0 was published to npm without a git tag; re-run the workflow after this merges to create the v11 / v11.0.0 tags.
Summary by CodeRabbit
- Chores
- Streamlined the release build process into a single consolidated build step.
- Preserved the correct build ordering for workspace packages while bundling the action and its dependencies.