fix(desktop): hold the GitHub credential check open while the e2e asserts its pending state

Merged
WA
1d ago
+17-7

Summary

  • The source-connect desktop e2e asserted GitHub pending is true during a fixed 500 ms delay on the credential check. expect.poll backs off to 1 s, so it can notice the check request after the response is back and the flag is false again — the long serial desktop release run lost that race on both attempts.
  • The fixture now holds the credential-check response until the test has seen the pending state, then releases it (in finally) and asserts the verified credential and pending: false as before. Same assertions, no timing window.

Type of Change

  • Bug fix

Testing

  • biome check on the changed spec
  • Desktop e2e (macOS) runs in CI via desktop-e2e for this path; not run locally

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)