fix(openfactor): stop patching generated hook plugins

Merged
SH
21d ago
+13-111

Summary

  • Remove the sed/perl rewrites of the generated OpenCode plugin and pi extension from config/openfactor/install.sh. The OpenFactor CLI now generates plugins that post events to the daemon socket in process, so there is no per-event spawn left to patch.
  • Drop the now-unused OPENFACTOR_PERL export from the activation script.
  • Replace the patch spec cases with one that asserts activation leaves the generated plugin files byte-for-byte unchanged.

Decisions

decided: keep the jq socket gate for JSON command hooks - Claude and Codex still run one command per event, so the gate remains the only way to skip them when no daemon listens.
decided: no compatibility branch for old CLI output - this merges only after the CLI release that generates in-process plugins, and activation runs openfactor upgrade before hooks install.

Verification

  • shellspec spec/openfactor_spec.sh: 10 examples, 0 failures.
  • shellcheck config/openfactor/install.sh spec/openfactor_spec.sh: clean.

🤖 Generated with Claude Code

Summary by cubic

Stops patching the generated OpenCode and pi hook plugins from config/openfactor/install.sh. The OpenFactor CLI now generates plugins that post events to the daemon socket in process, so the old sed/perl rewrites for spawn-per-event and pipe blocking are obsolete and would only corrupt the new output.

  • Drops the now-unused OPENFACTOR_PERL export from the activation script.
  • Replaces the patch spec cases with one asserting activation leaves plugins byte-for-byte unchanged.
  • Keeps the jq socket gate for JSON command hooks, since Claude and Codex still run one command per event.
  • No compatibility branch for old CLI output: activation runs openfactor upgrade before hooks install.

Verification: shellspec spec/openfactor_spec.sh (10 examples, 0 failures) and shellcheck pass.