fix: remove unused demo org display changes
Context & Requests for Reviewers
This PR is for this issue: https://github.com/roostorg/coop/issues/628. It is all the (non-database) changes to remove the use of demo organizations.
Tests
I've clicked around in the settings UI a little bit as a manual test. It doesn't look like tests included this field, so there weren't any existing tests to update.
The following screenshot shows the user experience for a "demo" user. Note that there was not any UI for marking a user as a demo user, so we don't expect that anyone reached this screen. Therefore, it should be fine to remove.
The following screenshot shows the same experience after the PR:
You'll notice that along with the "demo" callout being gone, the menu includes all the items
(Optional) Rollout Plan
Note that this change doesn't include the database change. I'll do that as a separate pr.
Checklist
Only check items that apply to this PR; leave the rest unchecked.
-
If you changed anything user-facing (i.e. user interface or APIs):
Did you update related docs? -
If the change is notable (refer to Keep a Changelog conventions):
Did you update CHANGELOG.md? -
If you changed
db/src/scripts/**and usedCREATE TABLE,ADD COLUMN, orALTER COLUMN:
Are as many columns markedNOT NULLas possible? If some columns can sometimes be null depending on other columns, are thereCHECKconstraints capturing those relationships, and are these also reflected using unions in the associated Kysely types? -
If you added a new signal in
server/services/signalsService/signals/**:
Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be aSignalPermanentError.