feat: implement issue #505 — SonarCloud: shell script hygiene

DO
11d ago
+8-8

Problem

SonarCloud: shell script hygiene

From the issue: 8 open SonarCloud finding(s) in petry-projects/markets, worst severity MAJOR. Generated by the org SonarCloud Audit.

Risk

Low — changes automation shell logic under scripts/, covered by shellcheck (--severity=warning) and the bats suite.

Test plan

No test files were added or updated. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's Lint (shellcheck) and bats checks show pass/fail; watch subsequent dev-lead / pr-review runs for behavioral regressions.

Closes #505

Summary by CodeRabbit

  • Chores
    • Updated internal repository scripts to use consistent Bash conditional syntax. Their checks and behavior are unchanged.