feat: implement issue #1125 — Fleet pr-review callers pin legacy bare pr-review/stable and are unmanaged — no pr-review release can reach the fleet

Merged
DO
7d ago
+512-19

Problem

Fleet pr-review callers pin legacy bare pr-review/stable and are unmanaged — no pr-review release can reach the fleet

From the issue: No pr-review release can reach the fleet through the normal path. Every fleet pr-review caller pins the legacy bare channel @pr-review/stable. Promotion moves only the major-scoped pr-review/v1-* channels. There is no standards/workflows/pr-review.yml template and pr-review.yml is not in DEPLOYABLE_WORKFLOWS, so the sweep never re-pins these callers.

Risk

Low — changes automation shell logic under scripts/, covered by shellcheck (--severity=warning) and the bats suite.

Test plan

Tests added/updated: test/scripts/deploy-standard-workflows/pr-review-replace-if-present.bats,test/scripts/lib/ring-pins.bats test/scripts/standards-templates/vform-pins.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's Lint (shellcheck) and bats checks show pass/fail; watch subsequent dev-lead / pr-review runs for behavioral regressions.

Closes #1125