feat: implement issue #2156 — dev-lead claim retraction does not cover issue-comment dispositions: a fixed reply for a commit that never landed stays up

Merged
DO
10d ago
+449-8

Problem

dev-lead claim retraction does not cover issue-comment dispositions: a fixed reply for a commit that never landed stays up

From the issue: When a dev-lead pass answers a PR issue comment it posts a reply marked disposition=fixed that cites a commit. If that commit never lands, the reply stays up saying "fixed". The claim-retraction sweep from #2013 does not look at these replies: retract_unlanded_claims (scripts/dev-lead-fix-reviews.sh) lists only pulls/{pr}/comments, the review-thread replies.

Risk

Low — changes automation shell logic under scripts/, covered by shellcheck (--severity=warning) and the bats suite.

Test plan

Tests added/updated: tests/dev-lead/unit/test_claim_landing.bats,tests/dev-lead/unit/test_claim_sweep.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's Lint (shellcheck) and bats checks show pass/fail; watch subsequent dev-lead / pr-review runs for behavioral regressions.

Closes #2156