feat: implement issue #2004 — A `fixed` disposition citing the WRONG sha can never verify — comment is never minimized, dev-lead refuses to re-answer, PR blocks permanently (#1977)

Merged
DO
1mo ago
+882-29

Problem

A fixed disposition citing the WRONG sha can never verify — comment is never minimized, dev-lead refuses to re-answer, PR blocks permanently (#1977)

From the issue: dev-lead can emit a fixed comment-disposition that cites the commit which introduced the finding instead of the commit that fixed it. The disposition then cannot verify, the harness never minimizes the original comment, the #1813 gate keeps withholding approval — and dev-lead will not re-answer, because its rule is "never re-answer my own disposition reply". The PR is then permanently unapprovable on work that was genuinely completed.

Risk

Low — changes automation shell logic under scripts/, covered by shellcheck (--severity=warning) and the bats suite.

Test plan

Tests added/updated: tests/dev-lead/unit/test_comment_disposition_verify.bats,tests/dev-lead/unit/test_fix_reviews.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's Lint (shellcheck) and bats checks show pass/fail; watch subsequent dev-lead / pr-review runs for behavioral regressions.

Closes #2004

AC5: #1977 already merged on a real pr-review approval, so there is nothing to unblock there. This PR builds on #2013 (merged to main earlier) and replaces the first attempt, #2011, which could not rebase and whose verifier failed open.