feat: implement issue #2038 — Markets collapse package §3/§4: re-render pr-auto-review and pr-review concurrency to ADR-0010 and mark the ruling ratified

Merged
DO
16d ago
+379-38

Problem

Markets collapse package §3/§4: re-render pr-auto-review and pr-review concurrency to ADR-0010 and mark the ruling ratified

From the issue: ADR-0010 is now accepted (#2010, #2036). It permits a bounded job-level concurrency: block on an agent-ingress.yml job, and the ADR's Consequences section records that the markets §3 rendering does not conform as written. docs/initiatives/agent-ingress-collapse-markets.md still shows the non-conforming blocks and still calls the §4 ruling "needs decision". The markets pilot (#1729, markets#506) cannot merge against it until the package matches the accepted schema.

Risk

Low — 6 file(s) changed; no CI- or runtime-critical paths touched.

Test plan

Tests added/updated: tests/agent_ingress_markets_package.bats,tests/fixtures/agent-ingress/markets-pinned-reusables/ci-failure-analyst-reusable.yml tests/fixtures/agent-ingress/markets-pinned-reusables/dev-lead-reusable.yml,tests/fixtures/agent-ingress/markets-pinned-reusables/pr-auto-review-reusable.yml tests/fixtures/agent-ingress/markets-pinned-reusables/pr-review.yml. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's CI checks (Lint + bats) are the success/regression signal.

Closes #2038

Refs #1729 and #2001.

Validator evidence: tests/agent_ingress_markets_package.bats extracts the §3 jobs from the doc and runs scripts/validate-ingress-if.sh and scripts/validate-caller-inputs.sh on them; it passes in CI (bats job green on this head).

Files beyond the doc and fixtures: .github/workflows/lint.yml adds the doc to the paths: filters and registers the new bats file (without it, doc-only edits skip the suite); AGENTS.md records that lint.yml entry as a repo-specific exception so a template sync does not revert it.