feat: implement issue #1919 — dev-lead's own unmarked acknowledgement comments block the approval they exist to unblock — 5 self-inflicted gate blockers on one PR

Merged
DO
1mo ago
+242-4

Problem

dev-lead's own unmarked acknowledgement comments block the approval they exist to unblock — 5 self-inflicted gate blockers on one PR

From the issue: dev-lead posts its acknowledgement of a non-actionable bot notice as a plain, unmarked PR issue comment. The maintainer-comment gate (#1290/#1813) classifies comments by marker, not by author — and dev-lead commits and comments as don-petry, a human login. So each acknowledgement is indistinguishable from a maintainer finding and becomes a new undispositioned comment that blocks the very approval it was posted to unblock.

Risk

Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.

Test plan

Tests added/updated: tests/dev-lead/unit/test_agent_marker_convention.bats,tests/dev-lead/unit/test_maintainer_comment_gate.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.

Closes #1919

Summary by CodeRabbit

  • Improvements
    • Automated review guidance now distinguishes verified clean status updates from other bot notices. Clean updates are handled without an informational reply; other notices receive a marked explanation only after their comment and author are verified.
    • Comments about failing-check fixes use a marker so they are not mistaken for unresolved findings. Replies within review threads remain unaffected.
  • Bug Fixes
    • Unmarked acknowledgements remain subject to approval checks; only comments with the appropriate marker are excluded.