chore(backend): drop the stale no-untyped-def mypy override for core.node.base

Merged
SA
3mo ago
+0-6

Summary

Removes the no-untyped-def mypy suppression on infrahub.core.node.base, restoring untyped-def checking on that module.

The module is already fully annotated — every def in backend/infrahub/core/node/base.py carries parameter and return types. The per-module override in pyproject.toml was therefore stale: it changed nothing about the current code and only served to hide future regressions. No source change was needed.

Resolves INBOX-30.

Changes

  • pyproject.toml — delete the [[tool.mypy.overrides]] block for module = "infrahub.core.node.base" (disable_error_code = ["no-untyped-def"]).

That is the entire diff: pyproject.toml | 6 ------.

Testing

Re-verified on the current head (a6c76a1e, after the merge from develop):

CheckResult
uv run mypy --show-error-codes backendSuccess — no issues found in 1610 source files
uv run invoke backend.lint (ruff, ty, mypy)All checks passed
uv run invoke backend.test-unit2233 passed
uv run invoke backend.validate-generatedNo drift
uv lock --checkLockfile in sync
CI on a6c76a1e41 passed, 15 skipped, 0 failed

Enforcement verified, not just assumed. To confirm the removal actually takes effect and is not shadowed by a broader override (infrahub.core.node is a separate entry and does not cover submodules), an untyped def was temporarily appended to the module:

backend/infrahub/core/node/base.py:69: error: Function is missing a type annotation  [no-untyped-def]

mypy flagged it as expected; the probe was then reverted (the diff above is the whole change).

Status

  • CI is fully green on a6c76a1e. The earlier red runs on this PR were never caused by its diff: python-lint was broken on develop itself (fixed independently by #10147), and the remaining failures were Actions infrastructure (queued-then-cancelled jobs, one OOM, one Neo4j deadlock at test setup). All resolved by the rebase @ogenstad asked for.
  • @ogenstad's approval is stale — it was recorded against aa469642c, before that rebase and the subsequent develop merge, so GitHub no longer counts it. A fresh look is needed before merge; review re-requested.
  • A changelog fragment was added initially and then dropped — a [[tool.mypy.overrides]] removal has no user-visible effect, so it does not warrant a release note.

🤖 Generated with Claude Code