fix(chat): name a new chat with the model the user chose
Description
Since #18305 (by @raunakab), the server names a new chat on a background thread while the first answer streams. The naming thread built its model from the chat session's saved agent and llm_override. The model that the user picks for a turn (SendMessageRequest.llm_override, or the parked or picker model) is not saved on the session. So when no chat-naming model was set, naming used the workspace default model, not the user's choice. With a private provider, the title was made by a model that the user did not choose.
test_llm_provider_called.py::test_user_sends_message_to_private_provider fails on every run since #18305 for this reason. The merge queue runs no external-dependency tests, so main did not catch it.
Behavior: when no Chat Naming Model is set, a new chat's title is made with the model that the user chose for the first message. An admin-set Chat Naming Model still takes priority.
Changes:
chat/execution.pygives the naming thread the turn's resolved model (setup.responses[0].llm).process_message.py:_select_modelsalready applied the user's choice, the incognito policy and the cost checks to this model.chat/session_naming.py:generate_chat_session_name_or_fallbacktakesget_chat_llm, a function that it calls only when no chat-naming model is set. The new-chat path passes the turn's model.PUT /chat/rename-chat-sessionkeeps its resolution from the session's agent and saved override, with the same lazy call. That endpoint generates a name only when the turn did not save one, which is rare. Its model choice is the same as before #18305.- The naming thread reads only committed state: the chat's name, record mode and first question.
reserve_chat_response_idscommits the question before the thread starts. #18305 moved nothing else onto the parallel path. - Three compaction tests counted every
invokecall on the chat's model as a summary. Naming now also calls that model, so these tests give their chat a name first, and naming does not run. - The admin docs and the feature map now say that naming uses the user's model when no Chat Naming Model is set.
How Has This Been Tested?
The tests ran against scratch Postgres, Redis and OpenSearch containers.
tests/external_dependency_unit/llm/test_llm_provider_called.py: fails onorigin/main(get_default_llm should not be called when using private provider, two runs). Passes with the fix (three runs).tests/unit/onyx/secondary_llm_flows/test_chat_session_naming.py: 8 passed. The newtest_new_chat_is_named_with_the_turns_modelchecks that the new-chat path generates with the turn's model and does not resolve a session model.tests/external_dependency_unit/llm/: 254 passed. 1 failed (test_chat_history_caching.py), because noANTHROPIC_API_KEYwas available locally. CI runs it.tests/external_dependency_unit/chatandanswer:test_chat_compaction.pypassed (12 tests). 14 other tests fail the same way onorigin/mainin the local environment: no LLM API keys, no code interpreter and no S3 file store. CI runs them.
Docs
- Customer-facing change: I updated
documentation/for the page's reader and task, at the level of detail of the whole page. - No docs change needed: the existing docs stay correct (internal, tests, CI, multi-tenant cloud only, or the UI explains it).
Additional Options
- [Optional] Please cherry-pick this PR to the latest release version.
š¤ Generated with Claude Code
Summary by cubic
Fixes new chat naming so the title is generated with the model the user chose for the first message instead of the workspace default model, which would otherwise be used even for private providers the user explicitly selected.
Details
- The naming thread now receives the turn's resolved model from
chat/execution.py; an admin-set Chat Naming Model still takes priority. PUT /chat/rename-chat-sessionkeeps its previous model resolution, which runs only when the turn didn't save a name.- Fixes the failing
test_user_sends_message_to_private_providerexternal dependency test; compaction tests now pre-name their chats since naming also invokes the chat model, and docs describe the new behavior.
Summary by CodeRabbit
- New Features
- When no chat-naming model is configured, new chats are named using the model selected for the conversation. A configured chat-naming model continues to take priority.
- Documentation
- Updated chat setup guidance to clarify which model is used to name chats when no chat-naming model is configured.