chore(chat): remove gather_stream and find_all_json_objects, which have no callers

Merged
DE
2h ago
+12-153

Description

This PR removes 2 helpers. Recent PRs left them with no callers outside tests.

  • gather_stream (backend/onyx/chat/process_message.py): #17295 moved its last caller, the Slack bot's handle_regular_answer.py, to gather_stream_full. This PR removes the function, its now-unused imports and test_process_message_gather_stream.py.
  • find_all_json_objects (backend/onyx/utils/text_processing.py): #17293 moved tool_parsing.py to iter_json_objects_with_spans. That removed the only caller. The existing ordering test now calls iter_json_objects_with_spans directly.

The feature-map docs (core-chat-loop.md, streaming-protocol.md) no longer refer to gather_stream.

I searched the whole repo for both names, including ee/, scripts and string-based patch(...) targets. No other references exist.

How Has This Been Tested?

  • pytest -n auto backend/tests/unit/onyx/{utils,chat,onyxbot,llm}: 3,136 passed.
  • ruff check passed, and the pre-commit hooks passed on commit.

Docs

  • Customer-facing change: I updated documentation/ (text and screenshots).
  • No docs change needed (internal, tests, CI, or multi-tenant cloud only).

Additional Options

  • [Optional] Please cherry-pick this PR to the latest release version.

Link to Devin session: https://app.devin.ai/sessions/32b3c703360b4dd1af57eec421fe2e28
Open in Devin Desktop: https://app.devin.ai/desktop/session/32b3c703360b4dd1af57eec421fe2e28?variant=devin

Summary by cubic

Removes gather_stream from backend/onyx/chat/process_message.py and find_all_json_objects from backend/onyx/utils/text_processing.py, both of which lost their last callers in recent refactors.

  • Deletes the now-unused imports and the gather_stream test file; the ordering test calls iter_json_objects_with_spans directly.
  • Updates the feature-map docs to remove gather_stream references.
  • Verified with the chat, utils, and onyxbot unit suites (3,136 tests passed) and ruff.