chore(indexing): remove unused IndexingCoordination.request_cancellation

Merged
DE
2d ago
+1-15

Description

#16391 changed _cancel_index_attempt in backend/onyx/server/documents/cc_pair.py to _cancel_index_attempt__no_commit. It now calls IndexingCoordination.request_cancellation__no_commit. That was the only caller of IndexingCoordination.request_cancellation, so this PR removes it.

  • Remove IndexingCoordination.request_cancellation from backend/onyx/db/indexing_coordination.py.
  • Change the reference in .agents/feature-map/components/indexing-pipeline.md to request_cancellation__no_commit.

How Has This Been Tested?

  • A search of the repo for request_cancellation finds no callers. The search covered backend, ee, tests and mock-patch strings.
  • prek run passes on the changed files (ty, ruff, feature map integrity).

Additional Options

  • [Optional] Please cherry-pick this PR to the latest release version.

Link to Devin session: https://app.devin.ai/sessions/a83c20c09124415fad8a6a274dce15d3
Open in Devin Desktop: https://app.devin.ai/desktop/session/a83c20c09124415fad8a6a274dce15d3?variant=devin

Summary by cubic

Removes the unused IndexingCoordination.request_cancellation method. Its only caller now uses request_cancellation__no_commit directly, so the wrapping method and its commit are dead code. Updates the indexing-pipeline feature map to reference the remaining method.

Summary by CodeRabbit

  • Documentation

    • Updated coordination documentation to reference the current cancellation workflow.

  • Bug Fixes

    • Cancellation requests now remain uncommitted until the calling process explicitly commits them, helping preserve transaction control and consistency.