fix(opal): redraw icons on a 16x16 viewBox, add file-type icons

Merged
RA
3d ago
+296-335

Description

This PR holds the icon changes that were first in #16275. It does not depend on that PR.

Why

  • Many Opal icons were drawn on viewBoxes other than 16×16: 24, 28, 32, 18, 15, or cropped to the path. At the same size, they rendered heavier, lighter or larger than the 16×16 icons. For example, the 28×28 x made every input clear button look small.

Redrawn at 16×16 (31 icons, converted from the mocks with scripts/convert-svg.sh; export names do not change)

  • alert-circle, arrow-down-dot, arrow-left-dot, arrow-right-dot, arrow-up-dot, arrow-up-down, arrow-wall-left, arrow-wall-right, bracket-curly, calendar, corner-right-up-dot, download, download-cloud, eye, eye-closed, files, link, log-out, mcp, menu, paint-brush, pause-circle, play-circle, stop-circle, text-lines, upload-cloud, x, x-circle, x-octagon, zoom-in, zoom-out.
  • download, arrow-wall-left and files were already 16×16. They are redrawn to match the mocks.

New icons

  • File types: binary-file, code-file, excel-file, executable-file, markdown-file, pdf-file, powerpoint-file, word-file, zip-file.
  • quote-lines.

Removed

  • pencil-ruler, quote-start, quote-end: they had no callers.
  • file-broadcast: it was the files icon on an 18×18 viewBox. The EE hooks page uses SvgFiles.
  • file-braces: its call sites use SvgCodeFile. These are the OpenAPI plugin icon and the fallback action icon in PluginsPage, MemberPluginsPage, PluginRow, ChatPluginsPopover and MemberPluginDetailModal, and getFileIcon for code files.
  • file-chart-pie: getFileIcon uses SvgPowerpointFile for .ppt and .pptx.

Still not 16×16: step1, step2, step3, step3-end, notification-bubble, blocks, handle.

Changes

image

Additional Options

  • [Optional] Please cherry-pick this PR to the latest release version.
  • [Optional] Override Linear Check

Summary by cubic

Redraws Opal icons that were on viewBoxes other than 16×16 (24, 28, 32, 18, 15, or path-cropped) so all icons render at a consistent weight and size at the same size; the 28×28 x made every input clear button look small. Adds the file-type icon set and quote-lines, removes the ad-hoc or unused duplicates, and drops the empty clip paths that were hiding six icons.

Removals and migrations

  • Removes pencil-ruler, quote-start, quote-end, file-broadcast, file-braces, and file-chart-pie.
  • The hooks page now uses SvgFiles, plugin pages use SvgCodeFile, and getFileIcon uses SvgPowerpointFile for .ppt/.pptx.

Summary by CodeRabbit

  • New Features

    • Added dedicated icons for binary, code, spreadsheet, executable, Markdown, PDF, presentation, document, and ZIP files.
    • File attachments now display more specific icons, including for code and presentation files.

  • Updates

    • Refreshed many icons for a more consistent 16×16 appearance.
    • Plugin and document-ingestion views now display updated icons.
    • Replaced the separate opening and closing quote icons with a single quote-lines icon.