fix: pin the runtime images (eMudhra CA fix) and accept the removed APIPriorityAndFairness gate

Merged
JE
4d ago
+215-9

Description

Two things, in three commits, for the release branches' next tags (release-1.9 → v1.9.2 for KubeVela 1.10 /
1.11, release-1.10 → v1.10.0-alpha.1 for KubeVela 1.12):

  1. The eMudhra CA fix. Both images run on a floating base: FROM alpine:3 (the gateway) and
    multiarch/alpine:${ARCH}-v3.13 (the addon-manager, end of life since 2022), so each build trusts whatever CA bundle
    Alpine had that day. Today's images (v1.9.0-alpha.2, v1.9.1, latest) trust the compromised eMudhra intermediate
    chains. Both now use alpine:3.24@sha256:3f4d6b32… (3.24.4, ca-certificates-bundle 20261020-r0), and the builder
    images are pinned by digest too. No Go version change: the gateway reads the system store.
    The addon-manager is built per architecture on one host (make ocm-addon-manager ARCH=…), so its runtime stage
    uses FROM --platform=linux/${ARCH} to pick that architecture's variant of the multi-arch base.

  2. KubeVela's chart passes a feature gate the gateway no longer has. Every vela-core chart (1.10, 1.11, 1.12) starts
    the gateway with --feature-gates=APIPriorityAndFairness=false,ClientIdentityPenetration=…. The gate was removed
    from Kubernetes, and the gateway since k8s.io/apiserver v0.31 exits on it ("unrecognized feature gate:
    APIPriorityAndFairness"). KubeVela's charts still run v1.9.0-alpha.2, so this hasn't shown yet, but any newer
    image under those charts crash-loops. featuregates.TranslateRemovedGates (called first in main) drops the gate
    and passes its value as --enable-priority-and-fairness, with a warning; an explicit
    --enable-priority-and-fairness wins. It's in pkg/featuregates because the Dockerfile and the Makefile build
    cmd/apiserver/main.go as a single file. KubeVela's charts will switch to --enable-priority-and-fairness=false
    too; this keeps the new images working under the charts already installed.

I have:

  • Signed off the commits (DCO).
  • Added a unit test (TestTranslateRemovedGates).

How has this been tested

  • Unit test (13 cases: KubeVela's args, the gate alone, the value as the next arg, a kube: prefix, the flag winning,
    no gate, --, a bare --feature-gates; and, after review, a gate without a value, empty, not a bool (all left for
    the parser to reject), False normalized, and pflag's next-arg behaviour).
  • Images built locally (gateway; addon-manager for amd64 and arm64, both on an arm64 host): Alpine 3.24.4 with
    ca-certificates-bundle 20261020-r0, each addon-manager image's architecture and binary matching its ARCH. Brotli:
    clean; eMudhra: no store trusts the compromised chains (Go effective trust 0/14).
  • Under KubeVela, unchanged charts (1.10.9, 1.11.1, 1.12.0-alpha.1) on k3d with a joined second cluster: the gateway
    starts with the chart's args, and join, probe, deploying an Application to the second cluster, updating it, reading it
    through the proxy (vela status, vela logs) and deleting it all work. With the same charts, today's release-*
    builds crash-loop on the removed gate.

Special notes for your reviewer

I'll cherry-pick these to release-1.10 (clean) and release-1.9 (its own builder digests; its main.go is the
apiserver-runtime one, so only the import block differs). Separately: KubeVela's charts in authentication mode also
need RBAC for validating admission policies with these newer gateways; that's a KubeVela chart change.


Summary by cubic

Pins the gateway and addon-manager runtime images to a fixed Alpine 3.24.4 digest (the eMudhra CA fix) and makes the gateway accept the removed APIPriorityAndFairness feature gate, so newer images no longer crash-loop under KubeVela's charts.

Today's releases float on alpine:3 (gateway) and the end-of-life multiarch/alpine:${ARCH}-v3.13 (addon-manager), so each rebuild trusts whatever CA bundle Alpine had that day; current images trust the compromised eMudhra intermediate chains. Both runtimes now use alpine:3.24.4 pinned by digest (with the fixed ca-certificates-bundle), builder images are pinned too, and the addon-manager's runtime stage uses --platform=linux/${ARCH} so an arm64 host can build the amd64 variant.

The gateway also translates --feature-gates=APIPriorityAndFairness=false — passed by every KubeVela chart — into --enable-priority-and-fairness=false before flags are parsed, since the gate was removed from Kubernetes and the apiserver exits on unknown gates since k8s.io/apiserver v0.31. Only boolean-valued gates are translated; malformed ones (missing, empty, or non-boolean values) are left for the parser to reject as before. An explicit --enable-priority-and-fairness flag wins; unit tests cover the chart's args and edge cases.